Fix create notes from RTN FORMATS desc for versions #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4472 As part of migrating the return requirement functionality from NALD to WRLS we've had to expand how the existing legacy code is importing the current from NALD. One of the changes we made was to capture the descriptions from each return version's return formats (return requirements) and combine them as the note. We don't intend to use `description` at the return requirement level but this is a way of still being able to capture the info and make them visible to users should they need them. However, we hadn't catered for the fact the files we're importing from state `'null'` for empty fields. This means `'null'` gets imported rather than the field being left as `NULL`. This messed up the notes because where there was no return format description `'null'` was being used, resulting in notes like 'null, null'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4472
As part of migrating the return requirement functionality from NALD to WRLS we've had to expand how the existing legacy code is importing the current from NALD.
One of the changes we made was to capture the descriptions from each return version's return formats (return requirements) and combine them as the 'note'. We don't intend to use
descriptionat the return requirement level, but this is a way of still being able to capture the info and make them visible to users should they need them.However, we hadn't catered for the fact that the files we're importing state
'null'for empty fields. This means'null'gets imported rather than the field being left asNULL. This messed up the notes because where there was no return format description,'null'was being used, resulting in notes like 'null, null'.