Update set to draft invalid return version query #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4612 https://eaflood.atlassian.net/browse/WATER-4510 > Part of the work to migrate return requirements from NALD to WRLS In [Set to 'draft' ret. versions with no requirements](#950) we added a query to deal with return versions imported from NALD with no return requirements. These shouldn't have been possible, because NALD doesn't have the concept of 'no returns required' return versions. So, these are just the result of NALD's rubbish data validation. We don't want them impacting the work we are doing, for example generating form logs or displaying return versions in the UI. But we also don't want them interfering with the 'no returns required' records we are adding, because WRLS _will_ have that ability. So, the query sets the status to 'draft' any return version that does not have any linked return requirements and where the reason is not one of our new 'no returns required' ones. That was till WATER-4612 changed what the 'no returns required' reasons are! This change updates the query to match the latest set of reasons.
Cruikshanks
added
the
housekeeping
Cruikshanks
requested review from
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4612
https://eaflood.atlassian.net/browse/WATER-4510
In Set to 'draft' ret. versions with no requirements we added a query to deal with return versions imported from NALD with no return requirements. These should have been impossible because NALD doesn't have the concept of 'no returns required' return versions. So, they are just the result of NALD's rubbish data validation.
We don't want them impacting our work, such as generating form logs or displaying return versions in the UI. But we also don't want them interfering with the 'no returns required' records we are adding because WRLS will have that ability.
So, the query sets the status to 'draft' any return version with no linked return requirements and where the reason is not one of our 'no returns required' ones.
That was till WATER-4612 changed what the 'no returns required' reasons are!
This change updates the query to match the latest set of reasons.