Remove note reset in Ret. Vers. note update #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Part of the work to migrate return version management from NALD to WRLS In [Fix return version note creation from requirements](#1004) we amended the way we were updating `water.return_versions` notes from `water.return_requirements` descriptions having spotted a flaw in the original logic. But because the flaw shipped, we needed to reset all notes before running the new version of the query. We only needed to run the reset once, but we don't have the luxury of doing that easily in production! So, instead we had the notes update query always run the reset before then updating the notes. The fix has [now been released](https://github.com/DEFRA/water-abstraction-import/releases/tag/v2.30.0) and we've confirmed it corrected the return version notes. So, we can remove the reset from the query we are running.
Cruikshanks
added
the
housekeeping
Now we know the notes are corrected, the only ones we need to set are new return versions inserted during the import. Everything else will already have had their notes set. This tweak ensures we are only updating those that have not yet had their note set.
Cruikshanks
requested review from
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
Beckyrose200
approved these changes
Aug 30, 2024
Jozzey
approved these changes
Aug 30, 2024
robertparkinson
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4472
In Fix return version note creation from requirements, we amended the way we updated
water.return_versionsnotes fromwater.return_requirementsdescriptions after spotting a flaw in the original logic.However, because the flaw shipped, we needed to reset all notes before running the new version of the query. We only needed to run the reset once, but we don't have the luxury of doing that easily in production!
So, instead, we had the notes update query always run the reset before updating the notes.
The fix has now been released, and we've confirmed it corrected the return version notes. So we can remove the reset from the query we are running.