New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCRM-4507 removed all references to removed getByPoint service #381

Merged

markfee merged 2 commits into master from fcrm-4507

Nov 21, 2023

Collaborator

markfee commented Nov 21, 2023

No description provided.


          FCRM-4507 removed all references to removed getByPoint service

0c3d5b1

markfee requested a review from Matthew-Collins-Defra

November 21, 2023 09:22

Matthew-Collins-Defra approved these changes

View reviewed changes

Matthew-Collins-Defra left a comment

lgtm. I was slightly worried that removing the implicit error checking from the passed in polygon (Json validation would throw exception on invalid input previously), but the service that's passed the data has robust error handling so should be good.


          Set Version to 2.7.0-pre.4

6ffa655

markfee merged commit 6ffa655 into master

3 checks passed

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet