Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cdms 142 #19

Merged
merged 9 commits into from
Dec 16, 2024
Merged

Feature/cdms 142 #19

merged 9 commits into from
Dec 16, 2024

Conversation

t11omas
Copy link
Contributor

@t11omas t11omas commented Dec 16, 2024

No description provided.

Thomas Anderson added 8 commits December 12, 2024 15:19
Initial attempt at decisions
90e06c2
Some updates to decisions, to refactor out into a matching service
cfa9e51
Merge remote-tracking branch 'origin/main' into feature/cdms-142
db8cc51 
# Conflicts:
#	Btms.Business/Extensions/ServiceCollectionExtensions.cs
#	Btms.Consumers.Tests/ClearanceRequestConsumerTests.cs
#	Btms.Consumers.Tests/NotificationsConsumerTests.cs
#	Btms.Consumers/AlvsClearanceRequestConsumer.cs
#	Btms.Consumers/NotificationConsumer.cs
#	Btms.Model/Alvs/Header.g.cs
#	Btms.Model/Movement.cs
merge conflicts
c9860bd
updated test data
c460554
updated generated code
496b6dd
reverted the decision finders back
2bfae18
commented out decisions as its not ready yet
10d6728
@t11omas t11omas requested a review from tstesyn December 16, 2024 08:24
@t11omas t11omas marked this pull request as ready for review December 16, 2024 08:25
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
Btms.Business 76% 42% ➖
Btms.Emf 11% 6% ❌
Btms.Types.Gvms.Mapping 38% 26% ❌
Btms.Metrics 82% 0% ✔
Btms.Types.Gvms 67% 100% ➖
Btms.Types.Alvs.Mapping 75% 0% ➖
Btms.Types.Ipaffs.Mapping 73% 31% ➖
Btms.Azure 43% 75% ❌
Btms.BlobService 32% 17% ❌
Btms.Backend 54% 53% ❌
Btms.Analytics 84% 62% ✔
Btms.Backend.Data 65% 61% ➖
Btms.Consumers 77% 66% ➖
Btms.Common 81% 25% ✔
Btms.Model 92% 95% ✔
Btms.SyncJob 81% 71% ✔
Btms.SensitiveData 80% 83% ✔
Btms.Types.Ipaffs 94% 56% ✔
Btms.Types.Alvs.Mapping.V1.Tests 0% 0% ❌
Btms.Types.Alvs 83% 67% ✔
TestDataGenerator 59% 44% ❌
Summary 73% (5931 / 8090) 48% (463 / 974) ➖

tstesyn
tstesyn approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@tstesyn tstesyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@t11omas t11omas merged commit 57113e3 into main Dec 16, 2024
1 check passed
@t11omas t11omas deleted the feature/cdms-142 branch December 16, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstesyn tstesyn tstesyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t11omas @tstesyn