Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes for poetry-based build to docker-compose.yml.development #1439

Merged
merged 2 commits into from
May 6, 2024

Conversation

dchiller
Copy link
Contributor

@dchiller dchiller commented May 6, 2024

#1429 introduced some changes to docker-compose.yml to support using poetry dependency management in the django container. I forgot to make the same changes to docker-compose.yml.development. h/t @lucasmarchd01 for this.

This PR makes those same changes to docker-compose.yml.development

@dchiller dchiller requested a review from lucasmarchd01 May 6, 2024 17:22
@dchiller dchiller marked this pull request as ready for review May 6, 2024 17:22
@lucasmarchd01
Copy link
Contributor

are we also including the args definition in docker-compose-development.yml for this PR?

@dchiller dchiller merged commit 0932bb5 into develop May 6, 2024
@dchiller dchiller deleted the fix-docker-compose-development branch May 6, 2024 17:32
@dchiller
Copy link
Contributor Author

dchiller commented May 6, 2024

are we also including the args definition in docker-compose-development.yml for this PR?

I should have! Will have to do another one facepalm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants