Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix Null when copying #14

Merged
merged 2 commits into from
Mar 2, 2024
Merged

[Fix] Fix Null when copying #14

merged 2 commits into from
Mar 2, 2024

Conversation

JXNCTED
Copy link

@JXNCTED JXNCTED commented Mar 1, 2024

This is a fix to #13, when copying the string constant can be null under the situation of:

  1. Editing the string constant inside GUI and save the settings
  2. Copy the entry

This fix adds:

  1. A sanity check to ensure the result on the clipboard does not contain null serializable string value
  2. Set the serialization when saving the setting via GUI.

JXNCTED added 2 commits March 1, 2024 18:52
@JXNCTED
Add a sanity check for null for clipboard content
4dc86bb 
Currenlty, the clipboard content can be null since the database
does not seem to be updating. This is a sanity check to prevent
the program from adding null to the clipboard.

Link to #13
@JXNCTED
[Fix] Add parsed serilization when save settings
765cb0e 
When loading from existing files or libraries, the parser will set
the serilization of the string constant to the correct value. However,
when editing via the GUI, the serilization was not set and a new
string constant list will be created without the serilization.
This result in the serilization being null and when copying with
the clipboard.

Link to #13
@JXNCTED JXNCTED requested a review from andersblomqvist March 1, 2024 19:31
andersblomqvist
andersblomqvist approved these changes Mar 2, 2024
View reviewed changes
Copy link

@andersblomqvist andersblomqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition and nice find regarding null values. If picky, this can be considered as fixing another issue but due to it was exposed by our feature I think it’s fine.

@andersblomqvist andersblomqvist merged commit ea946c4 into fix-for-issue-10872 Mar 2, 2024
@andersblomqvist andersblomqvist mentioned this pull request Mar 2, 2024
Closed
2 tasks
@JXNCTED JXNCTED deleted the issue-13/null-when-copying branch March 2, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersblomqvist andersblomqvist andersblomqvist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JXNCTED @andersblomqvist