Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Copy] The clipboard should copy referenced string constant only #15

Closed
JXNCTED opened this issue Mar 2, 2024 · 0 comments
Closed

[Copy] The clipboard should copy referenced string constant only #15

JXNCTED opened this issue Mar 2, 2024 · 0 comments
Assignees
@JXNCTED

Comments

@JXNCTED
Copy link

JXNCTED commented Mar 2, 2024

As the title suggested, when copying an entry or entires, only the referenced string constant should be added to the clipboard.
@JXNCTED JXNCTED self-assigned this Mar 2, 2024
JXNCTED added a commit that referenced this issue Mar 2, 2024
@JXNCTED
feat: Add parsed serialized string when cloning
b25bb92 
- Add parsed serialized string when cloning. When cloning, the new
onject will have null as parsed serialized string. This commit
adds the parsed serialized string to the cloned object.

Link to #15
JXNCTED added a commit that referenced this issue Mar 2, 2024
@JXNCTED
Fix: Setting parsed serialization failed tests
7fa29e9 
- Setting the parsed serialization will result in hasChanged being
set to true, which will cause the entry to be marked as changed. This
caused differences when the original entry was not serlized.

The fix has added a check of original entry to see if it has
parsed serialization, and if it does, it will be set to the new
entry.

Link to #15
JXNCTED added a commit that referenced this issue Mar 2, 2024
@JXNCTED
Feat: Add sanity check for null in ClipBoardManager
29e30dd 
To prevent copying null to the clipboard, we add a sanity check for null
before setting the content to the clipboard.

Link to #15
@JXNCTED JXNCTED mentioned this issue Mar 2, 2024
Merged
andersblomqvist pushed a commit that referenced this issue Mar 4, 2024
@JXNCTED
[Copy] Copy referenced constant strings to clipboard (#16)
404e781 
* feat: Add parsed serialized string when cloning
* feat: Add sanity check for null in ClipBoardManager
* closes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JXNCTED JXNCTED

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andersblomqvist @JXNCTED