Fix midi reset #179
Merged
Fix midi reset #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
processBlock shouldn't be called inside reset(). So now RenderEngine calls an extra processBlock at the end. Then each processor is responsible to look at the position info and stop MIDI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #178. PluginProcessor's reset implementation no longer calls processBlock. Now each call to render results in one extra call to processBlock, but the positionInfo's isRecording and isPlaying have been set to false. This allows each processor to behave differently inside its processBlock, such as making/consuming MIDI off events and ignoring other events.