Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK]: Grounding extra concept to be updated #6436 #6443

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[TASK]: Grounding extra concept to be updated #6436 #6443

wants to merge 9 commits into from

Conversation

dvince2
Copy link
Collaborator

@dvince2 dvince2 commented Feb 5, 2025

Description

  • Using the modifiers instead of context

Resolves #6436

@dvince2
[TASK]: Grounding extra concept to be updated #6436
fa20222 
Using the `modifiers` instead of `context`
@dvince2 dvince2 linked an issue Feb 5, 2025 that may be closed by this pull request
Grounding extra concept to be updated #6436
Open
@YohannParis YohannParis changed the base branch from main to release/v2.31.0 February 5, 2025 19:44
@dvince2 dvince2 requested a review from YohannParis February 5, 2025 19:51
@dgauldie
Copy link
Collaborator

dgauldie commented Feb 5, 2025

I'm confused now. I thought the modifiers were just used by MIRA to indicate stratification.

@dvince2
Copy link
Collaborator Author

dvince2 commented Feb 5, 2025

I'm confused now. I thought the modifiers were just used by MIRA to indicate stratification.

I'm going to defer to @YohannParis for this question

@YohannParis
Copy link
Member

I'm confused now. I thought the modifiers were just used by MIRA to indicate stratification.

I'm going to defer to @YohannParis for this question

Actually, this was a mistake on our parts.

context do not exist in the AMR Schema

Therefore they will be gone. This was after a debugging session with @bgyori into why some MIRA concept comparison method failed on the application.

Base automatically changed from release/v2.31.0 to main February 6, 2025 15:52
@YohannParis YohannParis self-assigned this Feb 6, 2025
@YohannParis YohannParis marked this pull request as draft February 6, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

@mloppie mloppie Awaiting requested review from mloppie mloppie is a code owner

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@YohannParis YohannParis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grounding extra concept to be updated
3 participants
@dvince2 @dgauldie @YohannParis