New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare scenario chart share intervention colouring with ranking charts #6333

Merged

dgauldie merged 8 commits into main from 6274-task-use-same-colour-in-compare-scenarios-than-in-raking-of-interventions

Jan 31, 2025

Contributor

mloppie commented Jan 31, 2025

Description

Pulls the intervention color palette creation out to a util to be shared.
Compare scenario charts now uses color to represent interventions
Coloring is consistent across ranking and comparison charts

Resolves #6274


          colour comparison chartshare intervention colourng with ranking charts

24fa304

mloppie requested review from YohannParis, mwdchang, jryu01, Tom-Szendrey, shawnyama, blanchco and asylves1 as code owners

January 31, 2025 17:14

mloppie linked an issue

that may be closed by this pull request

[TASK]: Use same colour in 'compare scenarios' than in 'Ranking of interventions' #6274

Closed

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/composables/useCharts.ts Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/composables/useCharts.ts Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/composables/useCharts.ts Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/composables/useCharts.ts Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/composables/useCharts.ts Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/composables/useCharts.ts Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/composables/useCharts.ts Outdated Show resolved Hide resolved

mloppie added 2 commits

January 31, 2025 14:27


          pr feedback, fix missing ranking chart

93f1086


          Merge branch 'main' into 6274-task-use-same-colour-in-compare-scenari…

f5ee485

…os-than-in-raking-of-interventions

shawnyama approved these changes

View reviewed changes

mloppie added 3 commits

January 31, 2025 15:27


          replace incomplete check with a note, use policy name from policy

caf6359


          Merge branch 'main' into 6274-task-use-same-colour-in-compare-scenari…

445280d

…os-than-in-raking-of-interventions


          Merge branch 'main' into 6274-task-use-same-colour-in-compare-scenari…

7b5b591

…os-than-in-raking-of-interventions

jryu01 approved these changes

View reviewed changes

mloppie added 2 commits

January 31, 2025 15:43


          lint

91a993e


          lint

3ae8bbd

dgauldie merged commit 1dc599c into main

2 checks passed

dgauldie deleted the 6274-task-use-same-colour-in-compare-scenarios-than-in-raking-of-interventions branch

January 31, 2025 20:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shawnyama shawnyama approved these changes

jryu01 jryu01 approved these changes

YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

blanchco Awaiting requested review from blanchco blanchco is a code owner

asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Labels

None yet