Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick question on the need for KeywordsStoppingCriteria #130

Open
sramakintel opened this issue Nov 30, 2024 · 0 comments
Open

Quick question on the need for KeywordsStoppingCriteria #130

sramakintel opened this issue Nov 30, 2024 · 0 comments

Comments

@sramakintel
Copy link

sramakintel commented Nov 30, 2024

Hello Team,

First off, thanks for your work! It is truly a great project!

Quick question on the KeywordsStoppingCriteria implementation. I see that it is a custom stopping criteria appended to other forms like EOSTokenCriteria,MaxLengthCriteria etc..

As far as I understood, The EOSTokenCriteria used here looks if the predicted token is an EOS token which is 151645 which I believe is the same as the KeywordsStoppingCriteria functionality where the ['<|im_end|>'] is tokenized as 151645. I feel they do the same thing. Return True if the predicted token is 151645.

I tried passing None to stopping_criteria here and it did not change the behavior. Is there a reason we need both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant