Fix channel closure and account tracking in callback package. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xekez
force-pushed
the
zeke/channel-closure-and-account-tracking
branch
from
74eee7d to
1d8e567
Compare
bekauz
reviewed
Apr 28, 2023
bekauz
approved these changes
Apr 28, 2023
0xekez
force-pushed
the
zeke/channel-closure-and-account-tracking
branch
from
1d8e567 to
4e1067f
Compare
Before this change: 1. The account map wasn't populated if no callback was requested during execution. 2. Sequence number wasn't namespaced by channel_id, which would cause incorrect callbacks to be sent in the event of a channel closing.
0xekez
force-pushed
the
zeke/channel-closure-and-account-tracking
branch
from
d706fc3 to
6c5177a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change: