chore: Apply Testcontainers for .NET best practices #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This is my first time using Testcontainers, so this PR was very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Applies Testcontainers for .NET best practices. It restructures and cleans up the Redis test fixture. The container object is not nullable,
InitializeAsyncandDisposeAsynccan immediately return their tasks, no reason toawait.It is recommended to use Testcontainers to resolve the hostname and public mapped port. Both properties may vary due to the Docker host. E.g. the hostname is not always
127.0.0.1orlocalhost.Why is it important?
I noticed you are using Testcontainers for .NET and wanna share some best practices.
Related issues
-