Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnaryResult.FromResult<T>(), UnaryResult.Nil #463

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Add UnaryResult.FromResult<T>(), UnaryResult.Nil #463

merged 2 commits into from
Sep 16, 2021

Conversation

mayuki
Copy link
Member

@mayuki mayuki commented Sep 16, 2021

Fixes #461

@mayuki mayuki requested a review from neuecc September 16, 2021 09:07
neuecc
neuecc approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good, thank you.
Andalso, what about UnaryResult<NIl> Nil => new UnaryResult<Nil>(Nil.Default)?

@mayuki
Copy link
Member Author

mayuki commented Sep 16, 2021

Thank you, I have also added UnaryResult.Nil as it is useful too.

@neuecc
Copy link
Member

neuecc commented Sep 16, 2021

thanks, perfect.

@mayuki mayuki merged commit ea589c3 into master Sep 16, 2021
@mayuki mayuki deleted the feature/UnaryResult.FromResult branch September 16, 2021 09:40
@mayuki mayuki changed the title Add UnaryResult.FromResult<T>() Add UnaryResult.FromResult<T>(), UnaryResult.Nil Sep 16, 2021
AntonC9018 pushed a commit to AntonC9018/MagicOnion that referenced this pull request Sep 13, 2022
@mayuki
Merge pull request Cysharp#463 from Cysharp/feature/UnaryResult.FromR…
5df3caf 
…esult

Add UnaryResult.FromResult<T>()
AntonC9018 pushed a commit to AntonC9018/MagicOnion that referenced this pull request Sep 13, 2022
@mayuki
Merge pull request Cysharp#463 from Cysharp/feature/UnaryResult.FromR…
7e87a8b 
…esult

Add UnaryResult.FromResult<T>()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuecc neuecc neuecc approved these changes

Assignees

@neuecc neuecc

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a static UnaryResult.FromResult helper (like Task.FromResult)
2 participants
@mayuki @neuecc