DAOs Lesson 6 - when executing, the address executing is different to the timelock address #3252
Answered
by
EngrPips
0xkieranwilliams
asked this question in
Q&A
-
|
Hey, any help on this would be greatly appreciated. Test setup function: function setUp() public {
govToken = new GovToken(address(this));
govToken.mint(USER, INITIAL_SUPPLY);
vm.startPrank(USER);
govToken.delegate(USER);
require(govToken.getVotes(USER) > 0, "User has no voting power");
timelock = new TimeLock(MIN_DELAY, proposers, executors);
governor = new MyGovernor(govToken, timelock);
console.log("timelock", governor.timelock());
bytes32 proposerRole = timelock.PROPOSER_ROLE();
bytes32 executorRole = timelock.EXECUTOR_ROLE();
bytes32 adminRole = timelock.DEFAULT_ADMIN_ROLE();
timelock.grantRole(proposerRole, address(governor));
timelock.grantRole(executorRole, address(0));
timelock.revokeRole(adminRole, USER);
vm.stopPrank();
box = new Box();
box.transferOwnership(address(timelock));
}it appears to fail when running this line in my test: governor.execute(targets, values, calldatas, descriptionHash);
Error and Logs:The error I am getting along with my logs is as follows. Any idea on why my Box contract is being called by an address different to the timelock (the address that box ownership has been transferred to)? |
Beta Was this translation helpful? Give feedback.
Answered by
EngrPips
Jan 14, 2025
Replies: 1 comment 5 replies
-
|
Hello @0xkieranwilliams, Run with |
Beta Was this translation helpful? Give feedback.
5 replies
-
|
Hi, thanks for responding. The repo with my current code can be found here: https://github.com/0xkieranwilliams/DAO-Contracts-Example/ Full error message with stack trace: ►► forge test -vvvv
[⠊] Compiling...
[⠒] Compiling 1 files with Solc 0.8.26
[⠑] Solc 0.8.26 finished in 1.60s
Compiler run successful!
Ran 2 tests for test/MyGovernorTest.t.sol:MyGovernorTest
[PASS] testCantUpdateBoxWithoutGovernance() (gas: 10439)
Logs:
timelock 0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353
Traces:
[10439] MyGovernorTest::testCantUpdateBoxWithoutGovernance()
├─ [0] VM::expectRevert(custom error 0xf4844814)
│ └─ ← [Return]
├─ [2424] Box::store(1)
│ └─ ← [Revert] OwnableUnauthorizedAccount(0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496)
└─ ← [Stop]
[FAIL: OwnableUnauthorizedAccount(0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496)] testGovernanceUpdatesBox() (gas: 480985)
Logs:
timelock 0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353
Proposal id: 33979103422727574184511916262680238047873831638657402714362624422030219988516
Proposal State: 0
Proposal State: 1
Proposal State: 4
box owner 0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353
timelock 0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353
governor 0x5929B14F2984bBE5309c2eC9E7819060C31c970f
Traces:
[7290952] MyGovernorTest::setUp()
├─ [1667394] → new GovToken@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
│ ├─ emit OwnershipTransferred(previousOwner: 0x0000000000000000000000000000000000000000, newOwner: MyGovernorTest: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496])
│ └─ ← [Return] 7977 bytes of code
├─ [97031] GovToken::mint(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], 100000000000000000000 [1e20])
│ ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], value: 100000000000000000000 [1e20])
│ └─ ← [Stop]
├─ [0] VM::startPrank(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ └─ ← [Return]
├─ [70208] GovToken::delegate(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ ├─ emit DelegateChanged(delegator: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], fromDelegate: 0x0000000000000000000000000000000000000000, toDelegate: us
er: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ ├─ emit DelegateVotesChanged(delegate: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], previousVotes: 0, newVotes: 100000000000000000000 [1e20])
│ └─ ← [Stop]
├─ [989] GovToken::getVotes(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D]) [staticcall]
│ └─ ← [Return] 100000000000000000000 [1e20]
├─ [1420273] → new TimeLock@0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353
│ ├─ emit RoleGranted(role: 0x0000000000000000000000000000000000000000000000000000000000000000, account: TimeLock: [0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353],
sender: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ ├─ emit RoleGranted(role: 0x0000000000000000000000000000000000000000000000000000000000000000, account: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], send
er: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ ├─ emit MinDelayChange(oldDuration: 0, newDuration: 3600)
│ └─ ← [Return] 6726 bytes of code
├─ [3597742] → new MyGovernor@0x5929B14F2984bBE5309c2eC9E7819060C31c970f
│ ├─ emit VotingDelaySet(oldVotingDelay: 0, newVotingDelay: 1)
│ ├─ emit VotingPeriodSet(oldVotingPeriod: 0, newVotingPeriod: 50400 [5.04e4])
│ ├─ emit ProposalThresholdSet(oldProposalThreshold: 0, newProposalThreshold: 0)
│ ├─ [405] GovToken::clock() [staticcall]
│ │ └─ ← [Return] 1
│ ├─ emit QuorumNumeratorUpdated(oldQuorumNumerator: 0, newQuorumNumerator: 4)
│ ├─ emit TimelockChange(oldTimelock: 0x0000000000000000000000000000000000000000, newTimelock: TimeLock: [0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353])
│ └─ ← [Return] 17349 bytes of code
├─ [442] MyGovernor::timelock() [staticcall]
│ └─ ← [Return] TimeLock: [0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353]
├─ [0] console::log("timelock", TimeLock: [0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353]) [staticcall]
│ └─ ← [Stop]
├─ [285] TimeLock::PROPOSER_ROLE() [staticcall]
│ └─ ← [Return] 0xb09aa5aeb3702cfd50b6b62bc4532604938f21248a27a1d5ca736082b6819cc1
├─ [286] TimeLock::EXECUTOR_ROLE() [staticcall]
│ └─ ← [Return] 0xd8aa0f3194971a2a116679f7c2090f6939c8d4e01a2a8d7e41d55e5351469e63
├─ [262] TimeLock::DEFAULT_ADMIN_ROLE() [staticcall]
│ └─ ← [Return] 0x0000000000000000000000000000000000000000000000000000000000000000
├─ [27571] TimeLock::grantRole(0xb09aa5aeb3702cfd50b6b62bc4532604938f21248a27a1d5ca736082b6819cc1, MyGovernor: [0x5929B14F2984bBE5309c2eC9E7819060C31c970f])
│ ├─ emit RoleGranted(role: 0xb09aa5aeb3702cfd50b6b62bc4532604938f21248a27a1d5ca736082b6819cc1, account: MyGovernor: [0x5929B14F2984bBE5309c2eC9E7819060C31c970f]
, sender: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ └─ ← [Stop]
├─ [27571] TimeLock::grantRole(0xd8aa0f3194971a2a116679f7c2090f6939c8d4e01a2a8d7e41d55e5351469e63, 0x0000000000000000000000000000000000000000)
│ ├─ emit RoleGranted(role: 0xd8aa0f3194971a2a116679f7c2090f6939c8d4e01a2a8d7e41d55e5351469e63, account: 0x0000000000000000000000000000000000000000, sender: user
: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ └─ ← [Stop]
├─ [5584] TimeLock::revokeRole(0x0000000000000000000000000000000000000000000000000000000000000000, user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ ├─ emit RoleRevoked(role: 0x0000000000000000000000000000000000000000000000000000000000000000, account: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], send
er: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ └─ ← [Stop]
├─ [0] VM::stopPrank()
│ └─ ← [Return]
├─ [147334] → new Box@0x2e234DAe75C793f67A35089C9d99245E1C58470b
│ ├─ emit OwnershipTransferred(previousOwner: 0x0000000000000000000000000000000000000000, newOwner: MyGovernorTest: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496])
│ └─ ← [Return] 617 bytes of code
├─ [2364] Box::transferOwnership(TimeLock: [0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353])
│ ├─ emit OwnershipTransferred(previousOwner: MyGovernorTest: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], newOwner: TimeLock: [0x7BD1119CEC127eeCDBa5DCA7d1Bd59
986f6d7353])
│ └─ ← [Stop]
└─ ← [Stop]
[480985] MyGovernorTest::testGovernanceUpdatesBox()
├─ [44832] MyGovernor::propose([0x2e234DAe75C793f67A35089C9d99245E1C58470b], [0], [0x6057361d0000000000000000000000000000000000000000000000000000000000000378], "st
ore what number in the Box?")
│ ├─ [405] GovToken::clock() [staticcall]
│ │ └─ ← [Return] 1
│ ├─ emit ProposalCreated(proposalId: 33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76], proposer: MyGovernorTest: [0x7FA9
385bE102ac3EAc297483Dd6233D62b3e1496], targets: [0x2e234DAe75C793f67A35089C9d99245E1C58470b], values: [0], signatures: [""], calldatas: [0x6057361d00000000000000000000
00000000000000000000000000000000000000000378], voteStart: 2, voteEnd: 50402 [5.04e4], description: "store what number in the Box?")
│ └─ ← [Return] 33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76]
├─ [0] console::log("Proposal id: ", 33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76]) [staticcall]
│ └─ ← [Stop]
├─ [2092] MyGovernor::state(33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76]) [staticcall]
│ ├─ [405] GovToken::clock() [staticcall]
│ │ └─ ← [Return] 1
│ └─ ← [Return] 0
├─ [0] console::log("Proposal State: ", 0) [staticcall]
│ └─ ← [Stop]
├─ [0] VM::roll(10002 [1e4])
│ └─ ← [Return]
├─ [0] VM::warp(12001 [1.2e4])
│ └─ ← [Return]
├─ [2473] MyGovernor::state(33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76]) [staticcall]
│ ├─ [405] GovToken::clock() [staticcall]
│ │ └─ ← [Return] 10002 [1e4]
│ └─ ← [Return] 1
├─ [0] console::log("Proposal State: ", 1) [staticcall]
│ └─ ← [Stop]
├─ [0] VM::prank(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D])
│ └─ ← [Return]
├─ [57961] MyGovernor::castVoteWithReason(33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76], 1, "I want it")
│ ├─ [405] GovToken::clock() [staticcall]
│ │ └─ ← [Return] 10002 [1e4]
│ ├─ [5935] GovToken::getPastVotes(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], 2) [staticcall]
│ │ └─ ← [Return] 100000000000000000000 [1e20]
│ ├─ emit VoteCast(voter: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], proposalId: 33979103422727574184511916262680238047873831638657402714362624422030219
988516 [3.397e76], support: 1, weight: 100000000000000000000 [1e20], reason: "I want it")
│ └─ ← [Return] 100000000000000000000 [1e20]
├─ [0] VM::roll(60403 [6.04e4])
│ └─ ← [Return]
├─ [0] VM::warp(616801 [6.168e5])
│ └─ ← [Return]
├─ [20610] MyGovernor::state(33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76]) [staticcall]
│ ├─ [405] GovToken::clock() [staticcall]
│ │ └─ ← [Return] 60403 [6.04e4]
│ ├─ [5765] GovToken::getPastTotalSupply(2) [staticcall]
│ │ └─ ← [Return] 100000000000000000000 [1e20]
│ └─ ← [Return] 4
├─ [0] console::log("Proposal State: ", 4) [staticcall]
│ └─ ← [Stop]
├─ [101212] MyGovernor::queue([0x2e234DAe75C793f67A35089C9d99245E1C58470b], [0], [0x6057361d0000000000000000000000000000000000000000000000000000000000000378], 0x88
b9b7474082452bf51da4a44469a1fc1f9e1b0db9c9b581599887607d86d93e)
│ ├─ [405] GovToken::clock() [staticcall]
│ │ └─ ← [Return] 60403 [6.04e4]
│ ├─ [1765] GovToken::getPastTotalSupply(2) [staticcall]
│ │ └─ ← [Return] 100000000000000000000 [1e20]
│ ├─ [2402] TimeLock::getMinDelay() [staticcall]
│ │ └─ ← [Return] 3600
│ ├─ [2505] TimeLock::hashOperationBatch([0x2e234DAe75C793f67A35089C9d99245E1C58470b], [0], [0x6057361d0000000000000000000000000000000000000000000000000000000000
000378], 0x0000000000000000000000000000000000000000000000000000000000000000, 0xd19006086906fecec5818a6da3e8319cdc828c02b9c9b581599887607d86d93e) [staticcall]
│ │ └─ ← [Return] 0x8094cd0822df348badc9c99373ebabb2f4ee8e2e83cb4607f5cf3e761e912f31
│ ├─ [33579] TimeLock::scheduleBatch([0x2e234DAe75C793f67A35089C9d99245E1C58470b], [0], [0x6057361d00000000000000000000000000000000000000000000000000000000000003
78], 0x0000000000000000000000000000000000000000000000000000000000000000, 0xd19006086906fecec5818a6da3e8319cdc828c02b9c9b581599887607d86d93e, 3600)
│ │ ├─ emit CallScheduled(id: 0x8094cd0822df348badc9c99373ebabb2f4ee8e2e83cb4607f5cf3e761e912f31, index: 0, target: Box: [0x2e234DAe75C793f67A35089C9d99245E1C5
8470b], value: 0, data: 0x6057361d0000000000000000000000000000000000000000000000000000000000000378, predecessor: 0x0000000000000000000000000000000000000000000000000000
000000000000, delay: 3600)
│ │ ├─ emit CallSalt(id: 0x8094cd0822df348badc9c99373ebabb2f4ee8e2e83cb4607f5cf3e761e912f31, salt: 0xd19006086906fecec5818a6da3e8319cdc828c02b9c9b581599887607d
86d93e)
│ │ └─ ← [Stop]
│ ├─ emit ProposalQueued(proposalId: 33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76], etaSeconds: 620401 [6.204e5])
│ └─ ← [Return] 33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76]
├─ [0] VM::roll(64004 [6.4e4])
│ └─ ← [Return]
├─ [0] VM::warp(660001 [6.6e5])
│ └─ ← [Return]
├─ [2312] Box::owner() [staticcall]
│ └─ ← [Return] TimeLock: [0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353]
├─ [0] console::log("box owner", TimeLock: [0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353]) [staticcall]
│ └─ ← [Stop]
├─ [0] console::log("timelock", TimeLock: [0x7BD1119CEC127eeCDBa5DCA7d1Bd59986f6d7353]) [staticcall]
│ └─ ← [Stop]
├─ [0] console::log("governor", MyGovernor: [0x5929B14F2984bBE5309c2eC9E7819060C31c970f]) [staticcall]
│ └─ ← [Stop]
├─ [51808] MyGovernor::execute([0x2e234DAe75C793f67A35089C9d99245E1C58470b], [0], [0x6057361d0000000000000000000000000000000000000000000000000000000000000378], 0x8
8b9b7474082452bf51da4a44469a1fc1f9e1b0db9c9b581599887607d86d93e)
│ ├─ [405] GovToken::clock() [staticcall]
│ │ └─ ← [Return] 64004 [6.4e4]
│ ├─ [1765] GovToken::getPastTotalSupply(2) [staticcall]
│ │ └─ ← [Return] 100000000000000000000 [1e20]
│ ├─ [734] TimeLock::isOperationPending(0x8094cd0822df348badc9c99373ebabb2f4ee8e2e83cb4607f5cf3e761e912f31) [staticcall]
│ │ └─ ← [Return] true
│ ├─ [33827] TimeLock::executeBatch([0x2e234DAe75C793f67A35089C9d99245E1C58470b], [0], [0x6057361d000000000000000000000000000000000000000000000000000000000000037
8], 0x0000000000000000000000000000000000000000000000000000000000000000, 0xd19006086906fecec5818a6da3e8319cdc828c02b9c9b581599887607d86d93e)
│ │ ├─ [23531] Box::store(888)
│ │ │ ├─ emit NumberChanged(: 888)
│ │ │ └─ ← [Stop]
│ │ ├─ emit CallExecuted(id: 0x8094cd0822df348badc9c99373ebabb2f4ee8e2e83cb4607f5cf3e761e912f31, index: 0, target: Box: [0x2e234DAe75C793f67A35089C9d99245E1C58
470b], value: 0, data: 0x6057361d0000000000000000000000000000000000000000000000000000000000000378)
│ │ └─ ← [Stop]
│ ├─ emit ProposalExecuted(proposalId: 33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76])
│ └─ ← [Return] 33979103422727574184511916262680238047873831638657402714362624422030219988516 [3.397e76]
├─ [416] Box::readNumber() [staticcall]
│ └─ ← [Revert] OwnableUnauthorizedAccount(0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496)
└─ ← [Revert] OwnableUnauthorizedAccount(0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496)
Suite result: FAILED. 1 passed; 1 failed; 0 skipped; finished in 8.96ms (2.74ms CPU time)
Ran 1 test suite in 992.32ms (8.96ms CPU time): 1 tests passed, 1 failed, 0 skipped (2 total tests)
Failing tests:
Encountered 1 failing test in test/MyGovernorTest.t.sol:MyGovernorTest
[FAIL: OwnableUnauthorizedAccount(0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496)] testGovernanceUpdatesBox() (gas: 480985) |
Beta Was this translation helpful? Give feedback.
-
|
Hello @0xkieranwilliams , inside of your function readNumber() public view onlyOwner returns (uint256){
return s_number;
} |
Beta Was this translation helpful? Give feedback.
Answer selected by
0xkieranwilliams
-
|
Thank you so much for that 🤦🏽♂️😂 |
Beta Was this translation helpful? Give feedback.
-
|
Anytime, My Friend. Keep crushing it. |
Beta Was this translation helpful? Give feedback.
-
|
great |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello @0xkieranwilliams , inside of your
Box.solcontract you applied onlyOwner to thereadNumberfunction, Please remove it then runforge cleanthen delete your cache folder if you have any then rerun your process.