Minimal Account testZkValidateTransaction() Assertion fail

[Totiruzi]

I ran the testZkValidateTransaction() with the flag --system-mode=true but I get an assertion error fail

Failing tests:
Encountered 1 failing test in test/zksync/ZkMinimalAccountTest.t.sol:ZkMinimalAccountTest
[FAIL: assertion failed: 0x0000000000000000000000000000000000000000000000000000000000000000 != 0x202bcce700000000000000000000000000000000000000000000000000000000] testZkValidateTransaction() (gas: 571649)

called test

function testZkValidateTransaction() public {
        // Arrange
        address dest = address(usdc);
        uint256 value = 0;
        bytes memory functionData = abi.encodeWithSelector(ERC20Mock.mint.selector, address(minimalAccount), AMOUNT);
        Transaction memory transaction =
            _createUnsignedTransaction(minimalAccount.owner(), 113, dest, value, functionData);
        transaction = _signTransaction(transaction);

        // Act
        vm.prank(BOOTLOADER_FORMAL_ADDRESS);
        bytes4 magic = minimalAccount.validateTransaction(EMPTY_BYTES32, EMPTY_BYTES32, transaction);

        // Assert
        assertEq(magic, ACCOUNT_VALIDATION_SUCCESS_MAGIC);
    }

    /**
     * HELPERS FUNCTIONS
     */
    function _signTransaction(Transaction memory transaction) internal view returns (Transaction memory) {
        bytes32 unsignedTransactionHash = MemoryTransactionHelper.encodeHash(transaction);
        uint8 v;
        bytes32 r;
        bytes32 s;
        uint256 ANVIL_DEFAULT_KEY = 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80;
        (v, r, s) = vm.sign(ANVIL_DEFAULT_KEY, unsignedTransactionHash);
        Transaction memory signedTransaction = transaction;
        signedTransaction.signature = abi.encodePacked(r, s, v);
        return signedTransaction;
    }
    ```
    
    Stack trace
    ```solidity
    gabdandom@fedora:~/Desktop/programming/web 3/foundary/account-abstraction$ forge test --mt testZkValidateTransaction --zksync -vvvv --system-mode=true 
[⠊] Compiling...
No files changed, compilation skipped
[⠃] Using zksolc-1.5.7
[⠊] Compiling (zksync)
No files changed, compilation skipped

Ran 1 test for test/zksync/ZkMinimalAccountTest.t.sol:ZkMinimalAccountTest
[FAIL: assertion failed: 0x0000000000000000000000000000000000000000000000000000000000000000 != 0x202bcce700000000000000000000000000000000000000000000000000000000] testZkValidateTransaction() (gas: 571649)
Traces:
  [598443283] ZkMinimalAccountTest::setUp()
    ├─ [496262276] → new ZkMinimalAccount@0xF9E9ba9Ed9B96AB918c74B21dD0f1D5f2ac38a30
    │   └─ ← [Return] 45920 bytes of code
    ├─ [640918] ZkMinimalAccount::transferOwnership(0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266)
    │   └─ ← [Return] 
    ├─ [101445433] → new ERC20Mock@0x6914631e3e71Bc75A1664e3BaEE140CC05cAE18B
    │   └─ ← [Return] 8608 bytes of code
    ├─ [0] VM::deal(ZkMinimalAccount: [0xF9E9ba9Ed9B96AB918c74B21dD0f1D5f2ac38a30], 1000000000000000000 [1e18])
    │   └─ ← [Return] 
    └─ ← [Stop] 

  [571649] ZkMinimalAccountTest::testZkValidateTransaction()
    ├─ [211993] ZkMinimalAccount::owner() [staticcall]
    │   └─ ← [Return] 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
    ├─ [0] VM::getNonce(ZkMinimalAccount: [0xF9E9ba9Ed9B96AB918c74B21dD0f1D5f2ac38a30]) [staticcall]
    │   └─ ← [Return] 0
    ├─ [0] VM::sign("<pk>", 0x751d3df1738ba7a144367c1788c5366a6bcbfe869be48b472969b83fad595965) [staticcall]
    │   └─ ← [Return] 28, 0x4e318addb586692f68fc14b177f5c20277d4c675621735318479992c958e27ba, 0x0b8eaa2539b0b18523c6384fef9f8fcf801176940fcec224107998507d2b0d14
    ├─ [0] VM::prank(0x0000000000000000000000000000000000008001)
    │   └─ ← [Return] 
    ├─ [340155] ZkMinimalAccount::validateTransaction(0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, Transaction({ txType: 113, from: 1390849295786071768276380950238675083608645509734 [1.39e48], to: 599898680248254702096213227986939319447011910027 [5.998e47], gasLimit: 16777216 [1.677e7], gasPerPubdataByteLimit: 16777216 [1.677e7], maxFeePerGas: 16777216 [1.677e7], maxPriorityFeePerGas: 16777216 [1.677e7], paymaster: 0, nonce: 0, value: 0, reserved: [0, 0, 0, 0], data: 0x40c10f19000000000000000000000000f9e9ba9ed9b96ab918c74b21dd0f1d5f2ac38a300000000000000000000000000000000000000000000000000de0b6b3a7640000, signature: 0x4e318addb586692f68fc14b177f5c20277d4c675621735318479992c958e27ba0b8eaa2539b0b18523c6384fef9f8fcf801176940fcec224107998507d2b0d141c, factoryDeps: [], paymasterInput: 0x, reservedDynamic: 0x }))
    │   └─ ← [Return] 0x00000000
    ├─ [0] VM::assertEq(0x0000000000000000000000000000000000000000000000000000000000000000, 0x202bcce700000000000000000000000000000000000000000000000000000000) [staticcall]
    │   └─ ← [Revert] assertion failed: 0x0000000000000000000000000000000000000000000000000000000000000000 != 0x202bcce700000000000000000000000000000000000000000000000000000000
    └─ ← [Revert] assertion failed: 0x0000000000000000000000000000000000000000000000000000000000000000 != 0x202bcce700000000000000000000000000000000000000000000000000000000

Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 116.41ms (22.54ms CPU time)

Ran 1 test suite in 926.96ms (116.41ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/zksync/ZkMinimalAccountTest.t.sol:ZkMinimalAccountTest
[FAIL: assertion failed: 0x0000000000000000000000000000000000000000000000000000000000000000 != 0x202bcce700000000000000000000000000000000000000000000000000000000] testZkValidateTransaction() (gas: 571649)

Encountered a total of 1 failing tests, 0 tests succeeded

I even copied Patrick's code and replaced it with mine but I still get the same error.

[EngrPips]

Hello @Totiruzi, The test is failing because the assertion isn't accurate, you should figure out why the magic returned from the call to
minimalAccount by the line of code below is not same as the value of ACCOUNT_VALIDATION_SUCCESS_MAGIC. It is not about copying and pasting patrick code but actually taking a step back to understand the process so as to figure something might be breaking. Also how did you compute the value for ACCOUNT_VALIDATION_SUCCESS_MAGIC or how did you get it?

bytes4 magic = minimalAccount.validateTransaction(EMPTY_BYTES32, EMPTY_BYTES32, transaction);

[EngrPips]

I expect it to work after you commented out return magic; It is weird that it didn't work. Did you save your file after making the changes? I will look into the code as soon as I can.

[Totiruzi]

Yes I did save my changes. Did a commit and pushed it off immediately.
Thanks a whole lot.

[EngrPips]

You are welcome, Friend.

[MichaelSukkiSong]

Hello, I had the same issue, and I think Patrick should mention that he changed the ZkMinimalAccount.sol to,

if (isValidSigner) { magic = ACCOUNT_VALIDATION_SUCCESS_MAGIC; } else { magic = bytes4(0); }

and not,

if (!isValidSigner) { magic = ACCOUNT_VALIDATION_SUCCESS_MAGIC; } else { magic = bytes4(0); }

if this is done, the test runs fine.

[EngrPips]

Great Heads-up.

[khixarcyber]

Hello bro, I'm facing an issue here. According to the error, even when I change the Solidity version, I still get the same error. Please guide me a bit; I would greatly appreciate your help

…

On Sat, Nov 30, 2024 at 12:13 PM EngrPips ***@***.***> wrote: You are welcome, Friend. — Reply to this email directly, view it on GitHub <#2917 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BMUCT5VN5X4QDRDHNDTJAF32DFQTFAVCNFSM6AAAAABSMKNTMCVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNBSGA3DSMQ> . You are receiving this because you commented.Message ID: <Cyfrin/foundry-full-course-cu/repo-discussions/2917/comments/11420692@ github.com>

[EngrPips]

Please provide more details about the issue you are facing so that people can help you.

[khixarcyber]

[EngrPips]

What version of solidity did you use inside SimpleStorage.sol?

[khixarcyber]

^0.0.19;

[khixarcyber]

[EngrPips]

Is this 0.0.19 or 0.8.19?

[khixarcyber]

0.0.19
"I have tried setting it to 0.8.19 in both places, but I am still getting the same error

[EngrPips]

Try 0.8.24 all through your codebase and see if the codebase will compile, I don't think there is a solidity version of 0.0.19. Also make sure to save you file when you make changes or else your changes won't be effective.

[khixarcyber]

,

I’m not sure, but I was following Patrick step by step, and I was at the step where we deploy the smart contract using Anvil. I think my PC might have turned off at that point, and maybe something didn’t save properly, which is why I’m getting this error. Even now, when I try to compile, I still get the same error.

[EngrPips]

I think the error is saying No solc version exists that matches the version requirement: ^0.0.19. Did I see correctly?

[khixarcyber]

So what should i do now?

On Mon, Dec 2, 2024 at 1:36 PM EngrPips ***@***.***> wrote: I think the error is saying No solc version exists that matches the version requirement: ^0.0.19. Did I see correctly? — Reply to this email directly, view it on GitHub <#2917 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BMUCT5UQJMX7GRPD2XI25FD2DQLXTAVCNFSM6AAAAABSMKNTMCVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNBTGQYDKNA> . You are receiving this because you commented.Message ID: <Cyfrin/foundry-full-course-cu/repo-discussions/2917/comments/11434054@ github.com>

I

[EngrPips]

If the error is indicating that you are using 0.0.19 version then that means your file changes wasn't saved or you are truly using version 0.0.19 which you are not supposed to be using because it doesn't exist. Maybe run forge clean then delete your cache folder then retry the compilation.

[Totiruzi]

Why don't you change the version to ^0.8.24. save the file and do a

forge clean

delete the cache folder and try again

[khixarcyber]

nahh bro it can't worked i am cooked

[khixarcyber]

I'll try that.

…

On Mon, Dec 2, 2024 at 2:45 PM Onowu Christopher Oyemechi < ***@***.***> wrote: Why don't you change the version to ^0.8.24. save the file and do a forge clean delete the cache folder and try again — Reply to this email directly, view it on GitHub <#2917 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BMUCT5SF3HLDXPEJCUPREWL2DQT27AVCNFSM6AAAAABSMKNTMCVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNBTGQ3TQNI> . You are receiving this because you commented.Message ID: <Cyfrin/foundry-full-course-cu/repo-discussions/2917/comments/11434785@ github.com>

[khixarcyber]

Hey bro, I tried this too, but I'm still getting the same error. I don't understand what I should do.

[EngrPips]

I am unsure what to suggest, Maybe restart the section.

[khixarcyber]

"I think there is also an issue with the imports: "-std/Scripforget.sol". What is your opinion about this?

[EngrPips]

The image you shared is not loading for me.

[khixarcyber]

ahhh do you use Instagram or X

[EngrPips]

I have both I don't heavily use them.

[khixarcyber]

[Totiruzi]

That import is wrong. It's suppose to be

import {Script} from "forge-std/Script.sol";

You have the forge part of the the import part beginning attached to the Script file name.
And also you have a double ^^ in your solidity compiler version specification

should be

pragma solidity ^0.8.0

[khixarcyber]

bro i still got same error 😭😭😭😭😭😭😭😭

[EngrPips]

This is the link https://github.com/Cyfrin/foundry-simple-storage-cu/blob/main/test/SimpleStorageTest.t.sol to Patrick code for this section you can check it to correct your mistakes.

check this repo it has the correct code.

[khixarcyber]

"I only pass in very basic things, but I still want to learn this. You all are seniors in this field

[EngrPips]

Me too but with persistency I am getting better, check the GitHub link I shared it has all the correct code.

[khixarcyber]

Thank you all very much! My code is finally compiling. I think my main issue was that my VS Code wasn’t updated promptly. Maybe that's why the solution you provided earlier didn’t work at first. Unfortunately, my VS Code wasn’t updated. By the way, I’m completely new to programming, so please don’t get annoyed by my silly questions. Treat me like your younger brother because I don’t have anyone else to learn from besides you

[EngrPips]

Hey buddy, It is totally fine and we understand. We will always do our best to help you through this journey of yours.

[Totiruzi]

Happy to know your code finally compiled. Your persistence to make sure you get things right is what you need and help you get better on this part.
There are no silly questions cause we all strive to get better.
So don't keep yourself in the dark by not asking a question tom clarify your understanding. It's either you get an answer or not!!!
So as @EngrPips will always say
"Keep crushing it my friend"
And soon you will unstuck yourself when you run into problems and helping other.

Cheers.