Lesson 9 [Smart Contract Lottery] - Testing RaffleNotOpen() #1754

DS-Coding0 · 2024-05-26T11:36:36Z

DS-Coding0
May 26, 2024

I tried to test if someone can enter is the Raffle is Calculating.
I get this error...

Ran 1 test for test/unit/RaffleTest.t.sol:RaffleTest
[FAIL. Reason: call did not revert as expected] testCantEnterWhenRaffleIsCalculating() (gas: 141282)
Logs:
  Creating subscription on ChainId:  31337
  Your sub ID is:  1
  Please update subscriptionId in HelperConfig.s.sol
  Funding subscription:  1
  Using vrfCoordinator:  0x90193C961A926261B756D1E5bb255e67ff9498A1
  On ChainID:  31337
  Adding consumer contract: 0x50EEf481cae4250d252Ae577A09bF514f224C6C4
  Using vrfCoordinator:  0x90193C961A926261B756D1E5bb255e67ff9498A1
  On ChainID:  31337

Traces:
  [42457679] RaffleTest::setUp()
    ├─ [21200301] → new DeployRaffle@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
    │   └─ ← [Return] 105685 bytes of code
    ├─ [21041192] DeployRaffle::run()
    │   ├─ [4515964] → new HelperConfig@0x104fBc016F4bb334D775a19E8A6510109AC63E00
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [1202082] → new VRFCoordinatorV2Mock@0x90193C961A926261B756D1E5bb255e67ff9498A1
    │   │   │   └─ ← [Return] 5781 bytes of code
    │   │   ├─ [746641] → new LinkToken@0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DefaultSender: [0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38], amount: 1000000000000000000000000 [1e24])
    │   │   │   └─ ← [Return] 3269 bytes of code
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   └─ ← [Return] 11593 bytes of code
    │   ├─ [963] HelperConfig::activeNetworkConfig() [staticcall]
    │   │   └─ ← [Return] 10000000000000000 [1e16], 30, VRFCoordinatorV2Mock: [0x90193C961A926261B756D1E5bb255e67ff9498A1], 0x474e34a077df58807dbe9c96d3c009b23b3c6d0cce433e59bbf5b34f823bc56c, 0, 500000 [5e5], LinkToken: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496]
    │   ├─ [4940735] → new CreateSubscription@0x037eDa3aDB1198021A9b2e88C22B464fD38db3f3
    │   │   └─ ← [Return] 24564 bytes of code
    │   ├─ [53045] CreateSubscription::createSubscription(VRFCoordinatorV2Mock: [0x90193C961A926261B756D1E5bb255e67ff9498A1])
    │   │   ├─ [0] console::log("Creating subscription on ChainId: ", 31337 [3.133e4]) [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [46789] VRFCoordinatorV2Mock::createSubscription()
    │   │   │   ├─ emit SubscriptionCreated(subId: 1, owner: DefaultSender: [0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38])
    │   │   │   └─ ← [Return] 1
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [0] console::log("Your sub ID is: ", 1) [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] console::log("Please update subscriptionId in HelperConfig.s.sol") [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   └─ ← [Return] 1
    │   ├─ [5035670] → new FundSubscription@0xDDc10602782af652bB913f7bdE1fD82981Db7dd9
    │   │   └─ ← [Return] 25038 bytes of code
    │   ├─ [6970] FundSubscription::fundSubscription(VRFCoordinatorV2Mock: [0x90193C961A926261B756D1E5bb255e67ff9498A1], 1, LinkToken: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496])
    │   │   ├─ [0] console::log("Funding subscription: ", 1) [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] console::log("Using vrfCoordinator: ", VRFCoordinatorV2Mock: [0x90193C961A926261B756D1E5bb255e67ff9498A1]) [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] console::log("On ChainID: ", 31337 [3.133e4]) [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [3178] VRFCoordinatorV2Mock::fundSubscription(1, 3000000000000000000 [3e18])
    │   │   │   ├─ emit SubscriptionFunded(subId: 1, oldBalance: 0, newBalance: 3000000000000000000 [3e18])
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   └─ ← [Stop] 
    │   ├─ [0] VM::startBroadcast()
    │   │   └─ ← [Return] 
    │   ├─ [567189] → new Raffle@0x50EEf481cae4250d252Ae577A09bF514f224C6C4
    │   │   └─ ← [Return] 2708 bytes of code
    │   ├─ [0] VM::stopBroadcast()
    │   │   └─ ← [Return] 
    │   ├─ [5691814] → new AddConsumer@0x7FdB3132Ff7D02d8B9e221c61cC895ce9a4bb773
    │   │   └─ ← [Return] 28314 bytes of code
    │   ├─ [51056] AddConsumer::addConsumer(Raffle: [0x50EEf481cae4250d252Ae577A09bF514f224C6C4], VRFCoordinatorV2Mock: [0x90193C961A926261B756D1E5bb255e67ff9498A1], 1)
    │   │   ├─ [0] console::log("Adding consumer contract:", Raffle: [0x50EEf481cae4250d252Ae577A09bF514f224C6C4]) [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] console::log("Using vrfCoordinator: ", VRFCoordinatorV2Mock: [0x90193C961A926261B756D1E5bb255e67ff9498A1]) [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] console::log("On ChainID: ", 31337 [3.133e4]) [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [47262] VRFCoordinatorV2Mock::addConsumer(1, Raffle: [0x50EEf481cae4250d252Ae577A09bF514f224C6C4])
    │   │   │   ├─ emit ConsumerAdded(subId: 1, consumer: Raffle: [0x50EEf481cae4250d252Ae577A09bF514f224C6C4])
    │   │   │   └─ ← [Stop] 
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   └─ ← [Stop] 
    │   └─ ← [Return] Raffle: [0x50EEf481cae4250d252Ae577A09bF514f224C6C4], HelperConfig: [0x104fBc016F4bb334D775a19E8A6510109AC63E00]
    ├─ [963] HelperConfig::activeNetworkConfig() [staticcall]
    │   └─ ← [Return] 10000000000000000 [1e16], 30, VRFCoordinatorV2Mock: [0x90193C961A926261B756D1E5bb255e67ff9498A1], 0x474e34a077df58807dbe9c96d3c009b23b3c6d0cce433e59bbf5b34f823bc56c, 0, 500000 [5e5], LinkToken: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496]
    ├─ [0] VM::deal(player: [0x44E97aF4418b7a17AABD8090bEA0A471a366305C], 10000000000000000000 [1e19])
    │   └─ ← [Return] 
    └─ ← [Stop] 

  [141282] RaffleTest::testCantEnterWhenRaffleIsCalculating()
    ├─ [0] VM::prank(player: [0x44E97aF4418b7a17AABD8090bEA0A471a366305C])
    │   └─ ← [Return] 
    ├─ [47734] Raffle::enterRaffle{value: 10000000000000000}()
    │   ├─ emit EnteredRaffle(player: player: [0x44E97aF4418b7a17AABD8090bEA0A471a366305C])
    │   └─ ← [Stop] 
    ├─ [0] VM::warp(32)
    │   └─ ← [Return] 
    ├─ [0] VM::roll(2)
    │   └─ ← [Return] 
    ├─ [69944] Raffle::performUpkeep(0x)
    │   ├─ [43604] VRFCoordinatorV2Mock::requestRandomWords(0x474e34a077df58807dbe9c96d3c009b23b3c6d0cce433e59bbf5b34f823bc56c, 1, 3, 500000 [5e5], 1)
    │   │   ├─ emit RandomWordsRequested(keyHash: 0x474e34a077df58807dbe9c96d3c009b23b3c6d0cce433e59bbf5b34f823bc56c, requestId: 1, preSeed: 100, subId: 1, minimumRequestConfirmations: 3, callbackGasLimit: 500000 [5e5], numWords: 1, sender: Raffle: [0x50EEf481cae4250d252Ae577A09bF514f224C6C4])
    │   │   └─ ← [Return] 1
    │   └─ ← [Stop] 
    ├─ [0] VM::expectRevert(Raffle__RaffleNotOpen())
    │   └─ ← [Return] 
    ├─ [0] VM::prank(player: [0x44E97aF4418b7a17AABD8090bEA0A471a366305C])
    │   └─ ← [Return] 
    └─ ← [Stop] 

Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 2.96ms (93.93µs CPU time)

Ran 1 test suite in 1.09s (2.96ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/unit/RaffleTest.t.sol:RaffleTest
[FAIL. Reason: call did not revert as expected] testCantEnterWhenRaffleIsCalculating() (gas: 141282)

Encountered a total of 1 failing tests, 0 tests succeeded

i checked all my code but don't find any problems.. and the -vvvv doesnt give me any answers, i think the raffle don't get closed if i look at the logs but i can't expect why..

i'll upload my code in repo in some minutes.

Answered by EngrPips

May 28, 2024

Below is the test stack trace from when I ran the same test.

Traces:
  [156571] LotteryTest::testCantEnterWhenRaffleIsCalculating()
    ├─ [0] VM::prank(player: [0x44E97aF4418b7a17AABD8090bEA0A471a366305C])
    │   └─ ← [Return] 
    ├─ [47808] Lottery::enter{value: 10000000000000000}()
    │   ├─ emit enteredLottery(player: player: [0x44E97aF4418b7a17AABD8090bEA0A471a366305C])
    │   └─ ← [Stop] 
    ├─ [0] VM::warp(32)
    │   └─ ← [Return] 
    ├─ [0] VM::roll(2)
    │   └─ ← [Return] 
    ├─ [75119] Lottery::performUpkeep(0x307830)
    │   ├─ [0] console::log("The address of the lottery contract is: ", Lottery: [0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0]) [staticcall]
    │   │   └─ ←

View full answer

EngrPips · 2024-05-26T16:49:43Z

EngrPips
May 26, 2024

Hello @DS-Coding0, Please post the code for the test so that we can gain more insight and possibly help.

3 replies

DS-Coding0 May 26, 2024
Author

The complete code is in my repo.

EngrPips May 26, 2024

Yeah, I know that, but I mean, show the code of the test you are running, and maybe with a quick look, we will be able to catch something

DS-Coding0 May 28, 2024
Author

Yeah, I know that, but I mean, show the code of the test you are running, and maybe with a quick look, we will be able to catch something

I use:

forge test --mt testCantEnterRaffleWhenCalculating

with this code:

function testCantEnterWhenRaffleIsCalculating() public {
        vm.prank(PLAYER);
        raffle.enterRaffle{value: entranceFee}();
        vm.warp(block.timestamp + interval + 1);
        vm.roll(block.number + 1);
        raffle.performUpkeep("");

        vm.expectRevert(Raffle.Raffle__RaffleNotOpen.selector);
        vm.prank(PLAYER);
        raffle.enterRaffle{value: entranceFee};
    }

EngrPips · 2024-05-28T09:03:09Z

EngrPips
May 28, 2024

Below is the test stack trace from when I ran the same test.

Traces:
  [156571] LotteryTest::testCantEnterWhenRaffleIsCalculating()
    ├─ [0] VM::prank(player: [0x44E97aF4418b7a17AABD8090bEA0A471a366305C])
    │   └─ ← [Return] 
    ├─ [47808] Lottery::enter{value: 10000000000000000}()
    │   ├─ emit enteredLottery(player: player: [0x44E97aF4418b7a17AABD8090bEA0A471a366305C])
    │   └─ ← [Stop] 
    ├─ [0] VM::warp(32)
    │   └─ ← [Return] 
    ├─ [0] VM::roll(2)
    │   └─ ← [Return] 
    ├─ [75119] Lottery::performUpkeep(0x307830)
    │   ├─ [0] console::log("The address of the lottery contract is: ", Lottery: [0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0]) [staticcall]
    │   │   └─ ← [Stop] 
    │   ├─ [44392] VRFCoordinatorV2Mock::requestRandomWords(0x474e34a077df58807dbe9c96d3c009b23b3c6d0cce433e59bbf5b34f823bc56c, 1, 3, 100000 [1e5], 1)
    │   │   ├─ [0] console::log("The msg sender for this requestRandomWords call is: ", Lottery: [0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0]) [staticcall]
    │   │   │   └─ ← [Stop] 
    │   │   ├─ emit RandomWordsRequested(keyHash: 0x474e34a077df58807dbe9c96d3c009b23b3c6d0cce433e59bbf5b34f823bc56c, requestId: 1, preSeed: 100, subId: 1, minimumRequestConfirmations: 3, callbackGasLimit: 100000 [1e5], numWords: 1, sender: Lottery: [0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0])
    │   │   └─ ← [Return] 1
    │   ├─ emit randomNumberRequested(requestId: 1)
    │   └─ ← [Stop] 
    ├─ [0] console::log(LotteryTest: [0x34A1D3fff3958843C43aD80F30b94c510645C316]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] VM::expectRevert(Lottery__LotteryIsCalculatingWinner())
    │   └─ ← [Return] 
    ├─ [0] VM::prank(player2: [0xEb0A3b7B96C1883858292F0039161abD287E3324])
    │   └─ ← [Return] 
    ├─ [404] Lottery::enter{value: 10000000000000000}()
    │   └─ ← [Revert] Lottery__LotteryIsCalculatingWinner()
    └─ ← [Stop] 

Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 30.26ms (1.92ms CPU time)

Ran 1 test suite in 4.76s (30.26ms CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)

Something i observed in your stack trace is for some reason the test didn't make the second enterRaffle call. Maybe you should try to confirm if this line of code raffle.enterRaffle{value: entranceFee}; actually hits when you ran the test.

0 replies

DS-Coding0 · 2024-05-28T09:37:48Z

DS-Coding0
May 28, 2024
Author

I need to open my eyes...

function testCantEnterWhenRaffleIsCalculating() public {
        vm.prank(PLAYER);
        raffle.enterRaffle{value: entranceFee}();
        vm.warp(block.timestamp + interval + 1);
        vm.roll(block.number + 1);
        raffle.performUpkeep("");

        vm.expectRevert(Raffle.Raffle__RaffleNotOpen.selector);
        vm.prank(PLAYER);
        raffle.enterRaffle{value: entranceFee};
    }

at
raffle.enterRaffle{value: entranceFee};
i forgot the "()"

1 reply

EngrPips May 28, 2024

Interesting. We often cause our problems most of the time, hahaha.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lesson 9 [Smart Contract Lottery] - Testing RaffleNotOpen() #1754

{{title}}

Replies: 3 comments 4 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

Lesson 9 [Smart Contract Lottery] - Testing RaffleNotOpen() #1754

DS-Coding0 May 26, 2024

Replies: 3 comments · 4 replies

EngrPips May 26, 2024

DS-Coding0 May 26, 2024 Author

EngrPips May 26, 2024

DS-Coding0 May 28, 2024 Author

EngrPips May 28, 2024

DS-Coding0 May 28, 2024 Author

EngrPips May 28, 2024

DS-Coding0
May 26, 2024

Replies: 3 comments 4 replies

EngrPips
May 26, 2024

DS-Coding0 May 26, 2024
Author

DS-Coding0 May 28, 2024
Author

EngrPips
May 28, 2024

DS-Coding0
May 28, 2024
Author