Refactor More Detector Names to suit //aderyn-ignore..
pattern
#739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow ups from
#737
Please feel free to improve them even more.
Basically what I'm looking for is that when we write
//aderyn-ignore(rule-name)
It should be CONSISTENT!
We "ignore" the "wrong" thing.
Therefore rule-name must specify the WRONG thing.
For example,
//aderyn-ignore(require-without-string)
instead of
//aderyn-ignore(require-with-string)
I get it that we want to have a string as explanation in the require statement. But .. that's where the description/recommendation/hint comes into play.
Tldr;
It should read like .... Here's the problem. and we're ignoring it
Not like .. Here's the correct thing to do .. and we're ignoring it.
Other examples that would make sense
//aderyn-allow-next-line(require-without-string)
//aderyn-allow-next-line(require-without-explanation)
ETC, ETC
@alexroan Please feel free to change it up as you see makes sense