Low Detector: Libraries and contracts should not live in same file #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need flexibility to organize solidity contracts and libraries the way we want (also helps for security scanning and verification) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severity: Low
Qualifications: All versions on solc
Logic:
If library contract is seen in a file that has other non-library contracts, we capture the library contract and suggest that it be moved to a different file.
Reason: Library contracts generally need floating pragmas to support a wide variety of contracts. If they are in a file same as contract, then this distinction is hard to support
No assoc. ADE
FOLLOW UP HERE 🙏 #740