-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector: Constant Function changing state #661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clippy cli/reportgen
heuristics to link state variables and storage pointers part 1 heuristics to link state variables and storage pointers part 2 heuristics to link state variables and storage pointers part 3
checkpoint 2 checkpoint 2 checkpoint 3 checkpoint 3 checkpoint 3
TilakMaddy
changed the title
Detector: Constant Function changing state
Detector: Constant Function changing state (can review)
Aug 12, 2024
TilakMaddy
changed the base branch from
feature/extract-written-state-variables
to
dev
August 12, 2024 11:58
TilakMaddy
changed the title
Detector: Constant Function changing state (can review)
Detector: Constant Function changing state
Aug 12, 2024
alexroan
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severity:
High
Qualification:
Pragma should support compilation below 0.5.0
Logic:
If the function changes state anywhere but is marked as
view
it will be captured (Pure did not exist for <0.5.0)