Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector: Constant Function changing state #661

Merged
merged 31 commits into from
Aug 19, 2024

Conversation

TilakMaddy
Copy link
Contributor

@TilakMaddy TilakMaddy commented Aug 12, 2024

Severity:
High

Qualification:
Pragma should support compilation below 0.5.0

Logic:
If the function changes state anywhere but is marked as view it will be captured (Pure did not exist for <0.5.0)

@TilakMaddy TilakMaddy changed the title Detector: Constant Function changing state Detector: Constant Function changing state (can review) Aug 12, 2024
@TilakMaddy TilakMaddy changed the base branch from feature/extract-written-state-variables to dev August 12, 2024 11:58
@TilakMaddy TilakMaddy changed the title Detector: Constant Function changing state (can review) Detector: Constant Function changing state Aug 12, 2024
@TilakMaddy TilakMaddy marked this pull request as ready for review August 12, 2024 11:59
@TilakMaddy TilakMaddy requested a review from alexroan as a code owner August 12, 2024 11:59
@alexroan alexroan merged commit 4909dad into dev Aug 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants