Relax fixed pragma constraints on library contract files (#740)

Co-authored-by: Alex Roan <[email protected]>

.github/workflows/cargo.yml

@@ -64,11 +64,6 @@ jobs:
         run: |
           git submodule update --init --recursive
 
-      - uses: Swatinem/rust-cache@v2
-      - name: Run cargo test 
-        run: |
-          cargo test _by_loading_contract_directly
-
       - uses: Swatinem/rust-cache@v2
       - name: Run cargo test 
         run: |

aderyn_core/src/detect/low/unspecific_solidity_pragma.rs

@@ -1,9 +1,12 @@
 use std::{collections::BTreeMap, error::Error};
 
 use crate::{
-    ast::NodeID,
+    ast::{ContractKind, NodeID, NodeType},
     capture,
-    context::workspace_context::WorkspaceContext,
+    context::{
+        browser::{ExtractContractDefinitions, GetClosestAncestorOfTypeX},
+        workspace_context::WorkspaceContext,
+    },
     detect::detector::{IssueDetector, IssueDetectorNamePool, IssueSeverity},
 };
 use eyre::Result;
@@ -18,8 +21,20 @@ pub struct UnspecificSolidityPragmaDetector {
 impl IssueDetector for UnspecificSolidityPragmaDetector {
     fn detect(&mut self, context: &WorkspaceContext) -> Result<bool, Box<dyn Error>> {
         for pragma_directive in context.pragma_directives() {
+            let Some(source_unit) =
+                pragma_directive.closest_ancestor_of_type(context, NodeType::SourceUnit)
+            else {
+                continue;
+            };
+            let contracts_in_source_unit = ExtractContractDefinitions::from(source_unit).extracted;
+            if contracts_in_source_unit
+                .iter()
+                .any(|c| c.kind == ContractKind::Library)
+            {
+                continue;
+            }
             for literal in &pragma_directive.literals {
-                if literal.contains('^') || literal.contains('>') {
+                if literal.contains('^') || literal.contains('>') || literal.contains('<') {
                     capture!(self, context, pragma_directive);
                     break;
                 }
@@ -88,4 +103,17 @@ mod unspecific_solidity_pragma_tests {
             )
         );
     }
+
+    #[test]
+    #[serial]
+    fn test_unspecific_solidity_pragma_detector_by_loading_contract_directly_on_library() {
+        let context = crate::detect::test_utils::load_solidity_source_unit(
+            "../tests/contract-playground/src/OnlyLibrary.sol",
+        );
+
+        let mut detector = UnspecificSolidityPragmaDetector::default();
+        let found = detector.detect(&context).unwrap();
+        // assert that the detector found an abi encode packed
+        assert!(!found);
+    }
 }