Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intro to explicitly linked elements #236

Merged
merged 11 commits into from
Jun 17, 2023
Merged

Conversation

jkowalleck
Copy link
Member

Try to clarify interlinked elements details

  • ref/link directions
  • link scopes: in-document, external
  • link target: external document, external element, internal element

this is intended to fix #136 and #217

@jkowalleck jkowalleck requested review from stevespringett and a team June 4, 2023 09:30
@jkowalleck
Copy link
Member Author

jkowalleck commented Jun 4, 2023

@stevespringett I started with the topic, to show my ideas.
I am not certain if this will make it into milestone 1.5 - depends on my progress.

Anyway, could you have a first review and tell me what you think about the general idea?
If the idea/concept is acceptable, I do need advice: are the details correct and did I miss any element that COULD be used as a BOM-Link?

I would start with the XSD and bring in the JSON schema if the XSD was complete.

Signed-off-by: Jan Kowalleck <[email protected]>
@stevespringett
Copy link
Member

Anyway, could you have a first review and tell me what you think about the general idea?

I like it. Although technically redundant (a BOM-Link is a URI), the fact the schema specifically calls it out I think is a good thing.

You captured all the places that a BOM-Link can be used. I would recommend proceeding and then spot check the formulation branch to see if there are others.

@jkowalleck
Copy link
Member Author

[...] a BOM-Link is a URI [...]

will change the special BOM-Link types to be based on anyURI/iri-reference, not simple strings.

Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
schema/bom-1.5.schema.json Show resolved Hide resolved
schema/bom-1.5.xsd Show resolved Hide resolved
@jkowalleck
Copy link
Member Author

jkowalleck commented Jun 5, 2023

I transferred all changes from XSD to JSON schema.

⚠️ In addition, I needed some clarity in bom.version, so I changed it to be a positive integer
see #236 (comment)
see #236 (comment)

@jkowalleck jkowalleck marked this pull request as ready for review June 5, 2023 08:00
@jkowalleck jkowalleck changed the title [WIP] intro to explicitely linked elements intro to explicitely linked elements Jun 5, 2023
@jkowalleck jkowalleck changed the title intro to explicitely linked elements intro to explicitly linked elements Jun 5, 2023
@jkowalleck jkowalleck linked an issue Jun 5, 2023 that may be closed by this pull request
@jkowalleck jkowalleck added this to the 1.5 milestone Jun 5, 2023
schema/bom-1.5.xsd Outdated Show resolved Hide resolved
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck
Copy link
Member Author

jkowalleck commented Jun 10, 2023

put to WIP again.
need to incorporate #228

PS: did backmerge of the master. noting else needed changes.

@jkowalleck jkowalleck marked this pull request as draft June 10, 2023 15:57
@jkowalleck jkowalleck marked this pull request as ready for review June 10, 2023 16:01
@stevespringett stevespringett merged commit 9730c9f into v1.5-dev Jun 17, 2023
@jkowalleck
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarify use of "bomlink" in schema
2 participants