Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDEA] added option postProcess #672

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[IDEA] added option postProcess #672

wants to merge 1 commit into from

Conversation

lal12
Copy link

@lal12 lal12 commented Feb 26, 2023

I want to do some custom addition/changes to the SBOM, due to a more complex webpack build structure for a project.

added option postProcess
31906ac 
Signed-off-by: Luca Lindhorst <[email protected]>
@lal12 lal12 requested a review from a team as a code owner February 26, 2023 22:33
@jkowalleck
Copy link
Member

jkowalleck commented Feb 27, 2023 •
edited
Loading

What kind of "more complex webpack build structure" do you have?
Could you provide a reproducible example and elaborate?

@jkowalleck
Copy link
Member

I will put this PR in "DRAFT" state.

Currently, such a feature is not planned. This plugin describes a closed process that has a defined start and end.
There is no feature request that describes the feature you implemented. Please create one and we can discuss goals/ideas/capabilities/responsibilities/requirements/boundaries of the problem/solution.

@jkowalleck jkowalleck marked this pull request as draft February 27, 2023 11:29
@jkowalleck jkowalleck changed the title added option postProcess [IDEA] added option postProcess Feb 27, 2023
jkowalleck
jkowalleck reviewed Feb 27, 2023
View reviewed changes
tests/integration/webpack5-react18/config/webpack.config.js
@@ -750,7 +750,10 @@ module.exports = function (webpackEnv) {
}),
new CycloneDxWebpackPlugin({
outputLocation: '.bom',
reproducibleResults: true
reproducibleResults: true,
postProcess: (bom) => {
Copy link
Member

@jkowalleck jkowalleck Feb 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ do not change existing tests.
write your own test case !

@lal12 lal12 mentioned this pull request Feb 27, 2023
Closed
@lal12
Copy link
Author

lal12 commented Feb 27, 2023

FR in #673

@jkowalleck
Copy link
Member

jkowalleck commented Dec 27, 2024 •
edited
Loading

Important

Reminder: this PR is intended to be kept around.
The connected feature might still be relevant for some, and the technical reasons why it is not considered/merged yet, might change in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowalleck jkowalleck jkowalleck left review comments

Assignees
No one assigned
Labels
idea
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lal12 @jkowalleck