feat: xml output omit defaultNS identifier #449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #438 BREAKING CHANGE Signed-off-by: Jan Kowalleck <[email protected]>
|
breaks for the following reasons: see #438 (comment) |
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
2 tasks
|
superseded by #458 |
jkowalleck
added a commit
that referenced
this pull request
Oct 4, 2023
add indention to outputters. this may come at a cost! Breaking Changes ------------------ * abstract Method `output.BaseOutput.output_as_string()` got new optional kwarg `indent` * abstract Method `output.BaseOutput.output_as_string()` accepts arbitrary kwargs Changed ---------- * XML output uses a default namespace, which makes results smaller. Added ------------------ * All outputters' method `output_as_string()` got new optional kwarg `indent` * All outputters' method `output_as_string()` accepts arbitrary kwargs * All outputters' method `output_to_file()` got new optional kwarg `indent` * All outputters' method `output_to_file()` accepts arbitrary kwargs ----- - [x] implementation - [x] tests (snapshot binary compare; structural equal compare) ----- enables CycloneDX/cyclonedx-python#424 fixes #437 fixes #438 supersedes #449 --------- Signed-off-by: Jan Kowalleck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #438
BREAKING CHANGE