Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: license factories #305

Merged
merged 6 commits into from
Sep 15, 2022
Merged

feat: license factories #305

merged 6 commits into from
Sep 15, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Sep 12, 2022 •
edited
Loading

fixes #304

related docs:

  • implement SPDX validation
  • implement factories
  • write tests for SPDX validation
  • write tests for factories

besides the new implementation and the new tests, the following changed:

  • poetry mentioned an outdated lock so i ran poetry lock --no-update
  • had to run poetry add --dev ddt
  • used poetry1.2
  • and since all of this caused a lot of failing CI, i handcrafted the poetry lockfile

@jkowalleck jkowalleck added the enhancement New feature or request label Sep 12, 2022
@jkowalleck jkowalleck force-pushed the license-factories branch 3 times, most recently from 30758d3 to e5e4b91 Compare September 12, 2022 21:31
@jkowalleck jkowalleck mentioned this pull request Sep 12, 2022
Closed
@jkowalleck jkowalleck force-pushed the license-factories branch 2 times, most recently from 2de641a to 9726c07 Compare September 13, 2022 07:37
@jkowalleck
feat: license factories
033bad2 
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the license-factories branch 4 times, most recently from 92db952 to 105f851 Compare September 13, 2022 18:18
@jkowalleck jkowalleck marked this pull request as ready for review September 13, 2022 18:18
@jkowalleck jkowalleck requested a review from a team as a code owner September 13, 2022 18:18
@jkowalleck
test: license factories
baf83f9 
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck
tests: rebase/fixup poetry lock
26817c0 
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck marked this pull request as draft September 14, 2022 07:01
@jkowalleck
tests: refactor tests
3644f13 
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck marked this pull request as ready for review September 14, 2022 11:00
@jkowalleck
Copy link
Member Author

ready for review

@madpah madpah merged commit 5ff4494 into main Sep 15, 2022
@madpah madpah deleted the license-factories branch September 15, 2022 07:01
@jkowalleck jkowalleck mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madpah madpah madpah approved these changes

Assignees

@madpah madpah

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] SPDX License factory
2 participants
@jkowalleck @madpah