document SBOM external references #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hboutemy
force-pushed
the
external-reference-doc
branch
from
aae4a13
to
e0e7a0f
Compare
Signed-off-by: Hervé Boutemy <[email protected]>
hboutemy
force-pushed
the
external-reference-doc
branch
from
e0e7a0f
to
df83d58
Compare
ppkarwasz
approved these changes
Jan 19, 2024
| @@ -215,7 +215,7 @@ private void checkTopLevelTestComponentsAsCompile(final File projDir) throws Exc | |||
|
|
|||
| /** | |||
| * This test ensures that any <i>compile</i> dependencies hidden by excluded types are included in the BOM if they are visible dependencies | |||
| * @throws Exception | |||
| * @throws Exception if something unexpected happens | |||
There was a problem hiding this comment.
Nit: we really need to document tests?
There was a problem hiding this comment.
or there is a warning at build time: just added minimum text to avoid warning
vy
suggested changes
Jan 19, 2024
Signed-off-by: Volkan Yazıcı <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default external references filled from POM + additional ones configured in plugin
while at it, also documented other fields converted from POM