-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support metadata when dependency is any other dependency type than jar #431
Conversation
Signed-off-by: Alberto Garcia-Muñoz <[email protected]>
can you provide a concrete example, please? |
@hboutemy We're currently using internal assets so I'm not able to share it with you. But, according to the official doc (https://maven.apache.org/pom.html#licenses), there's no limitation based on the type to declare the license inside of pom.xml. |
we'll need a test showing the change on test project (and avoid regression in the future) |
@hboutemy I've got one public dependency with zip packaging and license I don't really know how to add the test and the structure as I'm trying to create a pom within assets but as soon as I add zip it starts failing the install Do you have any guide on how to contribute to the tests? |
researching when/why this "limit to jar" feature was introduced, I found that it was done as a fix to #9 |
Signed-off-by: Hervé Boutemy <[email protected]>
Signed-off-by: Hervé Boutemy <[email protected]>
The plugin is currently limiting the metadata generation to the scenario where the artifact is a jar. However maven can support different types that support licensing such as zip