BOM string creation improvements #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
bom-str-fixes
branch
from
423da27 to
188f009
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
|
LGTM. @sschuberth Can you resolve the merge conflict? |
This is documentation for `toString()`, not for `toXmlString()`. Signed-off-by: Sebastian Schuberth <[email protected]>
Align JSON and XML functions to both throw to allow users to catch issues during string creations, as `toString()` swallows any exceptions silently. Signed-off-by: Sebastian Schuberth <[email protected]>
This aligns with `BomXmlGenerator`. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
bom-str-fixes
branch
from
188f009 to
36f8190
Compare
Done @nscuro. |
nscuro
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.