Improved secure mode warnings #1609
Merged
+316
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhu
commented
Jan 29, 2025
prabhu
commented
Jan 29, 2025
| @@ -411,6 +411,10 @@ const options = Object.assign({}, args, { | |||
| noBabel: args.noBabel || args.babel === false, | |||
| project: args.projectId, | |||
| deep: args.deep || args.evidence, | |||
| output: | |||
| isSecureMode && args.output === "bom.json" | |||
There was a problem hiding this comment.
Should we do this always or only in secure mode. Currently, the bom.json will be created in the current working directory.
prabhu
commented
Jan 29, 2025
| @@ -419,6 +423,13 @@ if (process.argv[1].includes("cbom")) { | |||
| options.specVersion = 1.6; | |||
| options.deep = true; | |||
| } | |||
| if (process.argv[1].includes("cdxgen-secure")) { | |||
| console.log( | |||
| "NOTE: Secure mode only restricts cdxgen from performing certain activities such as package installation. It does not provide security guarantees in the presence of malicious code.", | |||
There was a problem hiding this comment.
Wondering if we this message is enough. Should we use a different word instead of secure?
prabhu
commented
Jan 29, 2025
Signed-off-by: Prabhu Subramanian <[email protected]>
prabhu
force-pushed
the
feature/secure-mode-warnings
branch
from
c58b676 to
1aa6f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.