Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cldn 1968 (Display JSON data inline) #268

Merged
merged 21 commits into from
Mar 15, 2023
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
79388a2
Add buttons to expand and minimize JSON data as well as ability to ex…
cccs-Dustin Feb 8, 2023
6a43dfd
[CLDN-1968] Added expand button for full row
cccs-Dustin Feb 22, 2023
6031b34
[CLDN-1968] Resize JSON columns
cccs-Dustin Feb 24, 2023
dabc3da
[CLDN-1968] Added new array which tracks JSON cell state
cccs-Dustin Feb 27, 2023
2bc1814
Revert "[CLDN-1968] Added new array which tracks JSON cell state"
cccs-Dustin Feb 28, 2023
57b0ffd
[CLDN-1968] Added ability for row level expand all button to track if…
cccs-Dustin Feb 28, 2023
ca35c08
Merge branch 'cccs-2.0' into feature/CLDN-1968
cccs-Dustin Feb 28, 2023
05f8191
[CLDN-1968] Ran pre-commit hook
cccs-Dustin Mar 1, 2023
24d16a8
[CLDN-1968] Improved UI
cccs-Dustin Mar 1, 2023
60834d1
[CLDN-1968] Update image tag for testing
cccs-Dustin Mar 2, 2023
71f823b
[CLDN-1968] Revert image tag for testing
cccs-Dustin Mar 2, 2023
bc41022
[CLDN-1968] Added multiple UI/UX changes based on QA feedback
cccs-Dustin Mar 6, 2023
a3e8eb7
[CLDN-1968] Added more UI/UX changes based on QA feedback
cccs-Dustin Mar 6, 2023
57490bd
[CLDN-1968] Temp change to image
cccs-Dustin Mar 6, 2023
a2c6469
Revert "[CLDN-1968] Temp change to image"
cccs-Dustin Mar 7, 2023
ae44712
Update superset-frontend/src/cccs-viz/plugins/plugin-chart-cccs-grid/…
cccs-Dustin Mar 8, 2023
269e04a
[CLDN-1968] Remove 'TODO's as they are no longer needed
cccs-Dustin Mar 8, 2023
ae3fd27
[CLDN-1968] Changed a variable name, and condensed a few lines
cccs-Dustin Mar 8, 2023
8b415fa
[CLDN-1968] Modified a setState so that only one is needed instead of 2
cccs-Dustin Mar 8, 2023
3b7c350
[CLDN-1968] Fixed merge conflicts
cccs-Dustin Mar 13, 2023
6c89332
Merge branch 'cccs-2.0' into feature/CLDN-1968
cccs-Dustin Mar 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[CLDN-1968] Remove 'TODO's as they are no longer needed
cccs-Dustin committed Mar 8, 2023

Verified

This commit was signed with the committer’s verified signature.
commit 269e04a32e18c1e0e97b139d8fcaf8d4e00c2110
Original file line number Diff line number Diff line change
@@ -452,7 +452,6 @@ const config: ControlPanelConfig = {
return newState;
},
visibility: ({ controls }) =>
// TODO properly ensure is Bool
Boolean(controls?.emitFilter?.value),
canCopy: true,
},
@@ -591,7 +590,6 @@ config.controlPanelSections.push({
'Whether to enable row grouping (this will only take affect after a save). NOTE: "JSON Row Expand" and "Row Grouping" are mutually exclusive. If "Row Grouping" is selected, "JSON Row Expand" will not be visible.',
),
visibility: ({ controls }) =>
// TODO properly ensure is Bool
Boolean(!controls?.enable_json_expand?.value),
},
},
@@ -620,7 +618,6 @@ config.controlPanelSections.push({
'Whether to enable row level JSON expand buttons. NOTE: "JSON Row Expand" and "Row Grouping" are mutually exclusive. If "JSON Row Expand" is selected, "Row Grouping" will not be visible.',
),
visibility: ({ controls }) =>
// TODO properly ensure is Bool
Boolean(!controls?.enable_grouping?.value),
},
},