This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Fixed menu so it draws on top, various fixes/enhancements to stations #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-exit, character height now lowers when using a station to emulate sitting in a chair lowering ones head and vision.
CyanLaser
suggested changes
Jul 16, 2021
| if (!station.IsMobile) | ||
| { | ||
| characterController_.enabled = false; | ||
| station.EnterLocation.Translate(0f, -SITTING_HEIGHT_ADJUSTMENT_, 0f); |
There was a problem hiding this comment.
I'm concerned with moving the station's enter location directly. Since the enter location is just another transform, it could be moved through animation or other script and this has potential to mess that up. Could you change this to instead update the player's stance? This would move the camera up or down if they are in a station and not modify external objects.
…rouch/prone stances worked in chairs.
CyanLaser
approved these changes
Jul 16, 2021
| @@ -90,6 +92,7 @@ private enum Stance { | |||
| private CollisionFlags collisionFlags_; | |||
| private bool peviouslyGrounded_; | |||
| private bool legacyLocomotion_; | |||
| private bool updatePosition_; | |||
There was a problem hiding this comment.
Now that this is in a global scope, I would have renamed this to give it more context, but I'm not going to go super nit here and force you to change things just for this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the menu so it always draws on top.
Fixed stations to no longer auto-exit.
Added feature: Character height now lowers when using a station to emulate sitting in a chair lowering ones head and vision. The amount lowered is based on the average height loss for a humanoid which is about 55% height retained (or 45% lost). This can deviate slightly +/-5% depending on the age/height/sex of the human, but this seems like a good middle ground, especially since Avatars in VRC can be anything including generic non-humanoid, so we shouldn't need to be exact.