Replace custom vector to C++ std bitset class #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ergo720
reviewed
Mar 14, 2024
ergo720
reviewed
Mar 14, 2024
PatrickvL
reviewed
Mar 15, 2024
PatrickvL
reviewed
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101, #66
Per @PatrickvL suggestion to improve the loop process by using C++ standard library's bitset class which is supported by nxdk's C++ library. Doing so will require main.c rename to main.cpp and update makefile to use C++ compiler.
And updated the code to limit less than kernel_api_test_size can be set from input. Which then no longer needs a safety check inside for statement(s).
I have personally tested this with Cxbx-Reloaded to verify the exclusion(s) are working correctly and that all tests (except 0x77 test) are working as intended.