Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnitTest XONLINES verification for title(s) compiled with 4721 build #215

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

RadWolfie
Copy link
Member

This is a fixup for the unit test tool that somehow got missed after #159 pull request had been merged. Before the unit test tool #166 pull request had been pushed upstream. The fixup contains XOnline symbols from 4831 move to 4721 in unit test tool library verification.

Plus add a note of the recognized title, NBA 2K3, which has full library detection for DSOUND and XONLINES.

@github-actions github-actions bot added OOVPA Any OOVPA change relative needs-verification Require verification before approval DSOUND OOVPA relative topic XONLINE OOVPA relative topic labels Nov 30, 2024
@RadWolfie RadWolfie removed the needs-verification Require verification before approval label Nov 30, 2024
@github-actions github-actions bot added the needs-verification Require verification before approval label Dec 1, 2024
@RadWolfie RadWolfie removed the needs-verification Require verification before approval label Dec 1, 2024
@RadWolfie RadWolfie merged commit 7b9e2d4 into Cxbx-Reloaded:master Dec 1, 2024
14 checks passed
@RadWolfie RadWolfie deleted the fixup-unittest branch December 1, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DSOUND OOVPA relative topic OOVPA Any OOVPA change relative XONLINE OOVPA relative topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant