Improved code and tests.

Cumulocity-IoT · Nov 21, 2024 · bbd17c5 · bbd17c5
1 parent 1b53e15
commit bbd17c5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/c8y_api/model/_base.py b/c8y_api/model/_base.py
@@ -420,8 +420,7 @@ def get(self, path: str, default=None):
                 continue
             if hasattr(value, segment):
                 return value.__getattribute__(segment)
-            else:
-                return default
+            return default
         return value
 
     @deprecated
@@ -497,7 +496,6 @@ def build_object_path(self, object_id: int | str) -> str:
         """
         return self.resource + '/' + str(object_id)
 
-
     @staticmethod
     def _map_params(
             q=None,

diff --git a/tests/model/test_base.py b/tests/model/test_base.py
@@ -233,6 +233,7 @@ def test_complexobject_instantiation_and_formatting():
 
 
 def test_complexobject_get():
+    """Verify that get by path works as expected."""
 
     obj = ComplexTestObject(
         field='field value',
@@ -247,6 +248,8 @@ def test_complexobject_get():
     assert obj.get('c8y_complex.a') == obj.c8y_complex.a
     assert obj.get('not') is None
     assert obj.get('not', 'default') == 'default'
+    assert obj.get('c8y_complex.not') is None
+    assert obj.get('c8y_complex.not', 'default') == 'default'
 
 
 @pytest.mark.parametrize('page_size, num_all, limit, expected', [