Feature/28/metadata word sensibility #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanEduProjet
suggested changes
Dec 11, 2016
| @@ -99,6 +101,7 @@ void freeMetadata(Metadata *m) { | |||
| */ | |||
| void displayMetadata(const Metadata *m) { | |||
| printf("length: %zu\n", m->length); | |||
| printf("threshold: %zu\n", m->length); | |||
There was a problem hiding this comment.
m->threshold et non m->length
| "\t2. Search a similar word\n" | ||
| "\t0. Return to Dictionaries management\n\n"); | ||
| do { | ||
| printf("Your choice: "); | ||
| } while(!getIntRange(&choice, 0, 1)); | ||
| switch (choice) { | ||
| case 1: | ||
| menuChangeThreshold(dico->metadata, dico->filename); |
There was a problem hiding this comment.
Il ne serait pas plus propre de faire menuChangeThreshold(dico) et que ce soit dans la fonction qu'on accède au membres ?
There was a problem hiding this comment.
Non, une fonction ne doit prendre que ce qu'elle à besoin, et pas plus.
TristanEduProjet
suggested changes
Dec 11, 2016
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| typedef struct { | |||
There was a problem hiding this comment.
Il manque la documentation.
There was a problem hiding this comment.
Oui mais sur une autre PR
amelie-certin
approved these changes
Dec 11, 2016
TristanEduProjet
approved these changes
Dec 11, 2016
alex-lairan
force-pushed
the
feature/28/metadata_word_sensibility
branch
from
ab9088e to
8313261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.