Feature/36/levenshtein #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-lairan
requested changes
Dec 11, 2016
| * \param b Integer | ||
| * \return Integer the lower value between the two given Integers | ||
| */ | ||
| int min(int a, int b) { |
There was a problem hiding this comment.
Peux tu l'appeller minInt ?
| int last_cost = i + 1; | ||
| for (size_t j = 0; j < size2; j++) { | ||
| int sub_cost = (str1[i] == str2[j]) ? 0 : 1; | ||
| int cost = min(min(last_cost + 1, val[j + 1] + 1), val[j] + sub_cost); |
TristanEduProjet
suggested changes
Dec 11, 2016
| * \return Integer the distance between the two given strings | ||
| */ | ||
| int levenshtein(char *str1, char *str2) { | ||
| if (strcmp(str1, str2) == 0) { |
There was a problem hiding this comment.
Il serait peut-être mieux d'utiliser strcasecmp pour ne pas être sensible à la case ?
alex-lairan
approved these changes
Dec 11, 2016
amelie-certin
force-pushed
the
feature/36/levenshtein
branch
from
9e2e92c to
be9a7a3
Compare
TristanEduProjet
approved these changes
Dec 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveinshtein