EP-2560-QA-1 #1131
Merged
EP-2560-QA-1 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrandall22
requested changes
Jan 9, 2025
src/common/components/contactInfo/emailField/emailField.tpl.html
Outdated
Show resolved
Hide resolved
src/common/components/contactInfo/emailField/emailField.component.js
Outdated
Show resolved
Hide resolved
wrandall22
reviewed
Jan 9, 2025
wrandall22
reviewed
Jan 9, 2025
|
Let's squash the last 3 commits together, then it should be good to merge. |
wjames111
merged commit 806d875
into
EP-2517-branded-checkout-improvements
1 check passed
|
Sorry I thought I pressed squash and merge. |
|
You did. I would have preferred you squash the last 3 commits together and keep the first separate, then do a normal merge. |
|
Ahh okay sorry about that. Do you want me to try to fix it? |
|
Nope, too much trouble for what it's worth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From QA Mike requested "Email" and "Phone Number" be moved under "Organization Name". Conversation available in this ticket. I don't believe it's necessary to move Phone Number as it's already being hidden by useV3. I did use this as an opportunity to break out the email field into it's own component as it's being used twice in ContactInfo.