Replace make with invoke #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-add-invoke
branch
2 times, most recently
from
3ee5c62 to
1b4465e
Compare
lfdebrux
force-pushed
the
ldeb-add-invoke
branch
2 times, most recently
from
83cf1cf to
ec005d9
Compare
lfdebrux
force-pushed
the
ldeb-add-invoke
branch
from
ec005d9 to
b756bbb
Compare
lfdebrux
force-pushed
the
ldeb-add-invoke
branch
from
b756bbb to
6e07d82
Compare
alex9smith
approved these changes
Feb 25, 2021
We want to be able to reduce duplication of code across our repos; one of the places we have a lot of duplicated code is in our Makefiles; all of our repos have very similar Makefiles with small historical differences. This commit replaces Make with invoke, using the tasks from alphagov/digitalmarketplace-developer-tools. See Crown-Commercial-Service/digitalmarketplace-developer-tools#1 for more details.
lfdebrux
force-pushed
the
ldeb-add-invoke
branch
from
6e07d82 to
7835c31
Compare
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://trello.com/c/hCCo28Bc/1329-add-makefiles-to-digitalmarketplace-utils-and-reduce-duplication-across-apps
We want to be able to reduce duplication of code across our repos; one of the places we have a lot of duplicated code is in our Makefiles; all of our repos have very similar Makefiles with small historical differences.
This pull request replaces Make with invoke, using the tasks from alphagov/digitalmarketplace-dev-tools.
See Crown-Commercial-Service/digitalmarketplace-developer-tools#1 for more details.
Note: the tests won't pass until Crown-Commercial-Service/digitalmarketplace-developer-tools#1 is merged, as they now depend on invoke