Create user account email class #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for emailing a creation or invite email to a buyer or supplier is really similar. We're also moving these emails to Notify which also simplifies the process (no need for templates). This class can be imported by the frontend apps and used to generate and send the tokens and emails for user creation/invitiation.
allait
reviewed
Sep 22, 2017
dmutils/email/user_account_email.py
Outdated
| from .helpers import hash_string | ||
|
|
||
|
|
||
| class UserAccountEmail(): |
There was a problem hiding this comment.
This feels like this could be a function. Class attributes are essentially used as arguments for the single method.
Do you think this will get extended in the future in a way that would be easier to do with a class?
There was a problem hiding this comment.
Have updated to not be a class, and have imported the external blueprint from the supplier frontend.
As part of moving the logic for sending user account emails to a shared place in utils, we can move the external blueprints from the supplier frontend here too, and then import it in the app if needed. Other apps external blueprints could be moved here too and shared.
Wynndow
force-pushed
the
create-user-account-email-class
branch
from
0556bf4 to
8ab9bdc
Compare
allait
approved these changes
Sep 22, 2017
This changes the logic to a function which can be imported and used in the apps. It also imports the external blueprint which has been moved to utils. This means all logic can live in the function instead of having to pass in the url as before.
Wynndow
force-pushed
the
create-user-account-email-class
branch
from
8ab9bdc to
2578841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for emailing a creation or invite email to a buyer or supplier
is really similar. We're also moving these emails to Notify which also
simplifies the process (no need for templates).
This class can be imported by the frontend apps and used to generate and
send the tokens and emails for user creation/invitiation.