Skip to content

Commit

Permalink
Update dependency to use our fork of odfpy.
Browse files Browse the repository at this point in the history
 - this is to fix a bug in the odfpy library where it can
   produce non-well-formed XML;

 - note that in order for this requirement to be satisfied, you
   will have to update your requirements[-app].txt to include
   the new dependency;

 - we are avoiding using "dependency-links" in setup.py, because
   pip's support for that (i.e. via the `--process-dependency-links`
   option) is deprecated and has already disappeared once. (See
   <https://github.com/pypa/pip/pull/1955/files>.

https://trello.com/c/EgBoNeW9/145-certain-control-characters-in-suppliers-evidence-corrupts-the-ods-that-buyers-download
  • Loading branch information
galund committed Dec 6, 2017
1 parent e77fb9d commit 224c432
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 3 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@

Records breaking changes from major version bumps

## 31.0.0

PR: [#343](https://github.com/alphagov/digitalmarketplace-utils/pull/343)

Major version bump because we require users of this library to upgrade
to a version of the odfpy that is not in pypi.

ACTION: update your `requirements-app.txt`, copying the github URI in this
repo's `requirements.txt`.

## 30.0.0

PR: [#341](https://github.com/alphagov/digitalmarketplace-utils/pull/341)
Expand Down
2 changes: 1 addition & 1 deletion dmutils/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
import flask_featureflags # noqa


__version__ = '30.0.0'
__version__ = '31.0.0'
3 changes: 2 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
-e .
git+https://github.com/alphagov/odfpy.git@ee4482a#egg=odfpy==1.3.6dev
-e .
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
'mandrill==1.0.57',
'monotonic==0.3',
'notifications-python-client==4.1.0',
'odfpy==1.3.3',
'odfpy==1.3.6dev',
'python-json-logger==0.1.4',
'pytz==2015.4',
'pyyaml==3.11',
Expand Down

0 comments on commit 224c432

Please sign in to comment.