Add admin declaration feature #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors two step definitions to use less complex XPath selectors and introduce some new functionality. When I click the ? link for the supplier ? is functionally the same but changes large XPath into ruby code. The only addition it makes is to set the supplier name into the session as it is used later. I click the ? link for ? has changed to be closer to what the step definition is saying. Previously is built an HREF and tried to find it. This was brittle and did not transfer well to other uses. This change first finds the correct summary section with the summary heading and then finds the action link that follows it, checks it is correct and then clicks it.
The contents of the step definition meant that it could only ever be for the admin search page.
This step definition was parameterized but it could only be called with with specific parameters. This change makes the step explicit about that and refactors it contents. In the changes to it's contents it makes broadly the same checks but with less complex XPath. It also introduces the idea of different links being visible to different user types.
This also slightly refactors the login steps and adds explicit failures if unrecognised user types are used.
Now that we have features in subdirectories, if you want to fun a feature on it's own you have to provide this additional flag. I've added it here so that people don't have to remember to add it when they want to run a single feature file.
Admin users are required for the functional tests but we want them to be created manually to avoid the risk of creating admin users in production environments.
|
There is only one edit made in the tests. I think there should be at least two. One at the top and one in the middle as was discussed. CCS sourcing admin user creation is missing? |
Make another supplier declaration change in another section to show that different sections can be changed.
1 task
|
👍 |
robyoung
added a commit
that referenced
this pull request
Oct 14, 2015
Add admin declaration feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a feature testing supplier declaration editing from within the admin app.
This pull request also includes a few refactoring changes that are described in each of the commits.
Relates to
Depends on