remove use of FEATURE_FLAGS_NEW_SUPPLIER_FLOW, bump digitalmarketplace-utils to v43.0.0 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_brief_response logic we want to retire the use of flask feature flags and this is one of the last uses of them. previously we were comparing the `publishedAt` date with a feature flag's `enabled_since` date to determine whether it's a "legacy brief" or not. instead use the logic of `is_legacy_brief_response`, adapted from brief-responses-frontend, to figure this out. this function works by inspecting a brief *response*, so doesn't work in cases where there are no responses. fortunately the only bit of template that want to know its legacy status make no sense if there aren't any brief responses, so that largely solves that. update tests to provide information needed by `is_legacy_brief_response` in mocks.
katstevens
reviewed
Aug 24, 2018
| brief_responses_required_evidence = ( | ||
| None | ||
| if not brief_responses else | ||
| not is_legacy_brief_response(brief_responses[0], brief=brief) |
There was a problem hiding this comment.
Cool 👍I think it's a better explanation of what's happening than the alternative I just thought of...
... hardcoding a check for brief['publishedAt'][0:10] > '2017-02-08' - I mean, we wouldn't need separate checks for preview/staging as that data has long been wiped, but it feels a bit icky.
There was a problem hiding this comment.
Yeah, mine still isn't an ideal way, in that None is falsey, but meh...
|
Just waiting for the OK on this one now... |
katstevens
approved these changes
Aug 24, 2018
risicle
force-pushed
the
ris-flask-0-12
branch
from
498995b to
c8b94a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://trello.com/c/ZH9trgjH/419-snyk-alert-for-flask-010x-vulnerability
Crown-Commercial-Service/digitalmarketplace-utils#447
This one required a bit of fiddling to remove its use of feature flags. From the changeset comment:
In a better world someone would have stored the information as to whether a brief belonged to the old flow or new flow on the actual model in the first place, but it's too late for that.