digitalmarketplace-utils dependency: bump to 43.0.0, remove featureflags references, fix error handlers for flask 0.12 #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
approved these changes
Aug 24, 2018
katstevens
reviewed
Aug 24, 2018
| callbacks.app_errorhandler(code)(generic_error_handler) | ||
| if code in default_exceptions: # flask complains if we attempt to register a handler for status code its unaware of | ||
| main.app_errorhandler(code)(generic_error_handler) | ||
| callbacks.app_errorhandler(code)(generic_error_handler) |
There was a problem hiding this comment.
Can we just do for code in default_exceptions: and ditch the if?
There was a problem hiding this comment.
Mmmmmmmmmaybe... as long as we're 100% certain that werkzeug will only ever put 400 -> 599 status codes in there?
There was a problem hiding this comment.
If they do put extra ones in, we should probably handle them 😹
…ags references, fix error handlers for flask 0.12
risicle
force-pushed
the
ris-flask-0-12
branch
from
c919ace to
0694a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello https://trello.com/c/ZH9trgjH/419-snyk-alert-for-flask-010x-vulnerability
Crown-Commercial-Service/digitalmarketplace-utils#447
Only thing that stands out about this app is the changes I had to make to
generic_error_handlerto accommodate flask 0.12.