Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new arg for host regex, fix warnings, and errors #1163

Merged
merged 3 commits into from
May 31, 2024

Conversation

nickforsythbarr
Copy link
Contributor

Stale Sensors.py new feature, bug fixes

This pull request covers a couple of changes to to the stale_sensors.py.

I added functionality to support a new arg ("-p", "--host-pattern") which optionally accepts a string to filter the hosts by.

  • [ * ] Enhancement
  • [ * ] Bug fixes

Added features and functionality

  • added a new arg ("-p", "--host-pattern") to accept a regex argument to filter on hostname.

Issues resolved

  • fixed the calc_stale_date function that was complaining about deprecation.
  • changed the way the script calls the hide_hosts function to avoid the max simultaneous hosts API error.

@jshcodes jshcodes added code samples Functioning sample code to get you started hosts Hosts or Host Groups issues and questions labels May 28, 2024
@jshcodes jshcodes added bug 🐛 Something isn't working enhancement 🌟 New feature or request labels May 28, 2024
@jshcodes jshcodes changed the base branch from dev to samples May 28, 2024 19:12
@jshcodes
Copy link
Member

Unit testing failures are as expected. Testing locally. Linting issues will be resolved as part of the upcoming 1.4.4 code alignment and release. (Caused by updates in pylint.)

Copy link
Member

@jshcodes jshcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙇 🚀

@jshcodes jshcodes merged commit e59a053 into CrowdStrike:samples May 31, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working code samples Functioning sample code to get you started enhancement 🌟 New feature or request hosts Hosts or Host Groups issues and questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants