Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] Body payload parameter (sha256s) is mishandled in FalconXSandbox.query_sample #409

Closed
jshcodes opened this issue Nov 2, 2021 · 0 comments · Fixed by #410
Closed

[ BUG ] Body payload parameter (sha256s) is mishandled in FalconXSandbox.query_sample #409

jshcodes opened this issue Nov 2, 2021 · 0 comments · Fixed by #410
Assignees
@jshcodes
Labels
bug 🐛 Something isn't working documentation 📖 Improvements or additions to documentation Falcon Intelligence Falcon Intelligence issues and questions

Comments

@jshcodes
Copy link
Member

jshcodes commented Nov 2, 2021

Describe the bug
In FalconXSandbox.query_sample, the sha256s body payload parameter is mishandled. The payload handler is currently looking for the value of "sha256".

Docstring comment also incorrectly lists ids as the inbound keyword.

To Reproduce
Attempt to use FalconXSandbox.query_sample.

Expected behavior
The sha256s keyword is properly handled, creating the correct body payload.

Environment (please complete the following information):

  • OS: All supported
  • Python: All supported
  • FalconPy: 0.8.0 only

Additional context
Discovered while updating wiki documentation.
@jshcodes jshcodes added bug 🐛 Something isn't working documentation 📖 Improvements or additions to documentation Falcon Intelligence Falcon Intelligence issues and questions labels Nov 2, 2021
@jshcodes jshcodes self-assigned this Nov 2, 2021
jshcodes added a commit that referenced this issue Nov 2, 2021
@jshcodes
Fix typo and body payload param ref. Closes #409.
782f318
@jshcodes jshcodes mentioned this issue Nov 2, 2021
Merged
2 tasks
jshcodes added a commit that referenced this issue Nov 2, 2021
@jshcodes
[DEPLOY] (PATCH) v0.8.0 - Fix bad parameter reference in FalconXSandb…
c9fb452 
…ox.query_sample (#410)

* Fix typo and body payload param ref. Closes #409.

* Update CHANGELOG.md

* Update wordlist.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
bug 🐛 Something isn't working documentation 📖 Improvements or additions to documentation Falcon Intelligence Falcon Intelligence issues and questions
Projects
None yet
Milestone
No milestone
1 participant
@jshcodes