Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ ENH ] Add add_comment keyword argument to PerformIncidentAction operation #1003

Closed
jshcodes opened this issue Aug 2, 2023 · 0 comments · Fixed by #1036
Closed

[ ENH ] Add add_comment keyword argument to PerformIncidentAction operation #1003

jshcodes opened this issue Aug 2, 2023 · 0 comments · Fixed by #1036
Assignees
Labels
enhancement 🌟 New feature or request incidents Incidents issues and questions

Comments

@jshcodes
Copy link
Member

jshcodes commented Aug 2, 2023

          @jshcodes , sorry for commenting on a closed issue, but I just passed by as I saw the documentation at [falconpy.io](https://falconpy.io/Service-Collections/Incidents.html#performincidentaction) still states the same as the documentarion at [Swagger](https://assets.falcon.eu-1.crowdstrike.com/support/api/swagger-eu.html#/incidents/PerformIncidentAction);

Perform a set of actions on one or more incidents, such as adding tags or comments or updating the incident name or description

After some digging, I found that it is the documentation at https://falcon.eu-1.crowdstrike.com/documentation/86/detections-monitoring-apis#modify-incidents that is lacking details of the available action paramters. It is in fact possible to add a comment to an incident by using the action parameter name: "add_comment".

I guess it would be a good idea to update the documentations around :) And it would also be nice to have an own keyword argument for add_comment ;)

Originally posted by @morcef in #776 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request incidents Incidents issues and questions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant