fix: make pip package actually work #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the ability to install falcon-integration-gateway from the pypi repository and actually use it. A couple key changes were needed for this to work: 1. Needed to update the setup.py file to include the relevant directories that make the application work (ie fig/ config/) 2. Updated the config class to check the package level for the defaults.ini file as the fig needs this to instantiate 3. Updated the config class to allow using local config files for overrides. Now you can pip install falcon-integration-gateway, and add your config.ini file and let it rip. 4. Updated setup.py to reflect existing dependency with tlssyslog package. It's been deprecated and won't work with python 3.12+.
carlosmmatos
added
enhancement
redhatrises
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to install falcon-integration-gateway from the pypi repository and actually use it. A couple key changes were needed for this to work: