feat(eda): add ability to start stream from the latest event #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added additional buffer time to the aiohttp.ClientTimeout to not collide with the same timeout interval set for refreshing the stream. Also added some better exception handling surrounding potential timeout issues.
Fixes CrowdStrike#526 Fixes CrowdStrike#549 This option is mutually exclusive with offset, and if selected, will allow the event stream to always start from the latest event. This is useful for not having to manage the offset.
carlosmmatos
added
bugfixes
redhatrises
previously approved these changes
Aug 31, 2024
redhatrises
previously approved these changes
Aug 31, 2024
redhatrises
previously approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526
Fixes #549
This option is mutually exclusive with offset, and if selected, will allow the event stream to always start from the latest event. This is useful for not having to manage the offset.
This PR also fixes some issues with handling timeout due to refresh interval.