Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent spacing in error messages for create activity fields #1704

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix inconsistent spacing in error messages for create activity fields #1704

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1661a46
Fix inconsistent spacing in error messages for create activity fields
peoray Oct 17, 2023
be7bd74
Merge branch 'main' into inconsistent-spacing-error-messages
peoray Oct 19, 2023
b8e3cfd
Update activity form page with css style
peoray Oct 19, 2023
b65b20d
Merge branch 'inconsistent-spacing-error-messages' of github.com:peor…
peoray Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/src/shared/form/form-item.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,9 @@ export default {
name: 'AppFormItem',
};
</script>

<style scoped>
div.is-error {
margin-bottom: 40px;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do this in the Activity form component?
I'm afraid that with this change, it will affect all form-items throughout the app which can cause some unexpected visual changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the parent form div element for each field, the class appears twice or thrice in the case of the isError class
<div class="el-form-item mb-4 mb-4"> or <div class="el-form-item isError isError isError">

any idea why this is happening?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting 🤔
No, not sure why it is happening, also not being able to see it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll send a screenshot when I can. Strange that's happening only for me. Although the code should as expected baring this occurrence, it doesn't really affect anything

</style>
Loading